You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
tl;dr - I forked your (very good!) library. Are you interested in upstreaming the changes?
I'm in the unenviable position of needing to migrate a Node server that uses node-semver to golang without breaking any user who is currently relying on the logic in the Node library. Currently there is no equivalent semver library for Go that supports the range of inputs that the Node library does. Some examples:
To that end, I basically translated the (regex heavy) logic from the Node library directly and added it as a pre-processing step that normalizes the above input into the >=1.2.3 <2.0.0 type ranges that your library expects.
I'm happy to either clean up these changes and upstream them into your library, or fork and support as a separate semver library for those who need these other features and something that is compatible with Node's semver library. Or I can maintain my fork separately if you are not interested.
👋 Hi there!
tl;dr - I forked your (very good!) library. Are you interested in upstreaming the changes?
I'm in the unenviable position of needing to migrate a Node server that uses node-semver to golang without breaking any user who is currently relying on the logic in the Node library. Currently there is no equivalent semver library for Go that supports the range of inputs that the Node library does. Some examples:
To that end, I basically translated the (regex heavy) logic from the Node library directly and added it as a pre-processing step that normalizes the above input into the
>=1.2.3 <2.0.0
type ranges that your library expects.Changes here: master...jmorrell:master
I'm happy to either clean up these changes and upstream them into your library, or fork and support as a separate
semver
library for those who need these other features and something that is compatible with Node'ssemver
library. Or I can maintain my fork separately if you are not interested.Downsides:
Benchmark after changes:
Your repo on master on the same machine:
The text was updated successfully, but these errors were encountered: