Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing today in unix format works fine but not with other dates #309

Closed
sushmar-sportsbet opened this issue Sep 12, 2024 · 8 comments · Fixed by #312
Closed

Parsing today in unix format works fine but not with other dates #309

sushmar-sportsbet opened this issue Sep 12, 2024 · 8 comments · Fixed by #312

Comments

@sushmar-sportsbet
Copy link

Hi, I'm having an issue while parsing the following input in Template to render.

{% assign today = 'now' | date: '%s' %}. → gives parsing outcome as → 1726121266// correct output
{% assign mar_1st = '1 Mar' | date: '%s' %} -> gives parsing outcome as → 1 Mar //incorrect output expecting unix format

@bkiers @msangel Will you please review this one?

@msangel
Copy link
Collaborator

msangel commented Sep 12, 2024

@sushmar-sportsbet sure will take a look

@sushmar-sportsbet
Copy link
Author

Hello @msangel any update on this one? We need this feature for our current development work. Thanks

@bkiers
Copy link
Owner

bkiers commented Nov 18, 2024

I can have a look at this @sushmar-sportsbet

@bkiers
Copy link
Owner

bkiers commented Nov 18, 2024

@sushmar-sportsbet the issue was not that 1 Mar could not be converted to a timestamp, but it could not be parsed to a date. Fixed in #312

@msangel
Copy link
Collaborator

msangel commented Nov 18, 2024

I have draft for much better solution but have no time to finish it. And this one is good and will work.

@msangel
Copy link
Collaborator

msangel commented Nov 19, 2024

Released as 0.9.1.2

@sushmar-sportsbet
Copy link
Author

sushmar-sportsbet commented Nov 26, 2024

When are you planning to release the version 0.9.1.2?

@bkiers
Copy link
Owner

bkiers commented Nov 26, 2024

@sushmar-sportsbet 0.9.1.2 is already released: https://central.sonatype.com/artifact/nl.big-o/liqp/versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants