Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous space character is present solely between each icon of "Quick copy actions". #12985

Open
1 task done
RokeJulianLockhart opened this issue Jan 20, 2025 · 2 comments
Labels
browser Browser Extension bug

Comments

@RokeJulianLockhart
Copy link
Contributor

RokeJulianLockhart commented Jan 20, 2025

Steps To Reproduce

  1. Installed Fedora-KDE-Live-x86_64-41-1.4.iso.

  2. Installed google-noto-sans-mono-fonts-20240701-2.fc41.noarch.rpm:

    1. #!/usr/bin/env sh
      dnf info google-noto-sans-mono-fonts
    2. Updating and loading repositories:
      Repositories loaded.
      Installed packages
      Name            : google-noto-sans-mono-fonts
      Epoch           : 0
      Version         : 20240701
      Release         : 2.fc41
      Architecture    : noarch
      Installed size  : 20.5 MiB
      Source          : google-noto-fonts-20240701-2.fc41.src.rpm
      From repository : anaconda
      Vendor          : Fedora Project
  3. Installed firefox-134.0.1-1.fc41.x86_64.rpm.

  4. Set the undermentioned preferences (in firefox 'about:config'), which I did via about:preferences#general:~:text=Fonts, so this is officially supported by Mozilla:

      1. #!/usr/bin/env sh
        firefox 'about:config#:~:text=browser.display.use_document_fonts'
      2. "browser.display.use_document_fonts": 0
      1. #!/usr/bin/env sh
        firefox 'about:config#:~:text=font.name.monospace.x%2Dwestern'
      2. "font.name.monospace.x-western": "monospace"

    Note that fc-match monospace returns NotoSansMono-Regular.ttf: "Noto Sans Mono" "Regular", per the undermentioned (hence the aforementioned installation of google-noto-sans-mono-fonts-20240701-2.fc41.noarch):

    1. #!/usr/bin/env sh
      fc-match monospace
    2. NotoSansMono-Regular.ttf: "Noto Sans Mono" "Regular"
  5. Installed bitwarden_password_manager-2024.12.4.xpi.

  6. Visited /popup/index.html#/appearance:~:text=Show%20quick%20copy%20actions%20on%20vault.

  7. Enabled "Quick copy actions".

Expected Result

There shouldn't be a space character between the icons. The icons that don't have one remain adequately padded regardless.

Actual Result

As aforestated at community.bitwarden.com/t/76836/532#p-166311-button-spacing-is-inconsistent-1:

There’s a single Unicode space between the username, password, and TOTP generation clipboard duplication buttons, which aren’t present between the TOTP generation clipboard duplication and overflow buttons.

This inconsistency reduces space available whilst providing no increase to the affected buttons’ invocation targets.

Screenshots or Videos

Image

Additional Context

I presume that the reason that this was missed was that it's solely noticeable when utilizing a monospace font. However, because monospace fonts are more readable for those with dyslexia, 1 this can't be remediated by advising users to merely not utilize monospace typefaces.

Operating System

Linux

Operating System Version

Fedora-KDE-Live-x86_64-41-1.4.iso:

  1. #!/usr/bin/env sh
    kinfo
  2. Operating System: Fedora Linux 41
    KDE Plasma Version: 6.2.5
    KDE Frameworks Version: 6.10.0
    Qt Version: 6.8.1
    Kernel Version: 6.12.9-200.fc41.x86_64 (64-bit)
    Graphics Platform: Wayland

Web Browser

Firefox

Browser Version

firefox-134.0.1-1.fc41.x86_64.rpm:

  1. #!/usr/bin/env sh
    dnf info firefox
  2. Updating and loading repositories:
    Repositories loaded.
    Installed packages
    Name            : firefox
    Epoch           : 0
    Version         : 134.0.1
    Release         : 1.fc41
    Architecture    : x86_64
    Installed size  : 224.2 MiB
    Source          : firefox-134.0.1-1.fc41.src.rpm
    From repository : @stored_transaction
    Vendor          : Fedora Project

Build Version

bitwarden_password_manager-2024.12.4.xpi

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

Footnotes

  1. Revision (no date) User Experience Stack Exchange. Available at: ux.stackexchange.com/revisions/48777/5 (Accessed: 20 January 2025).

@RokeJulianLockhart RokeJulianLockhart added browser Browser Extension bug labels Jan 20, 2025
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-17350

@NovaSilentium
Copy link

Hi there,

This has been escalated for further investigation. If you have more information that can help us, please add it below.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests

3 participants