Use a function to define file_name

[philippze]

Very nice module!

I've added the method get_file_name to the ExcelView in analogy to get_queryset which is inherited by View. I need this flexibility for one of my projects. Should I push it to your repository?

[bitterjug]

Hi! Delighted to have a user.
Sure; is there a test for it?

Mark

On Wed, Oct 9, 2013 at 9:44 AM, Philipp Zedler [email protected]:

Very nice module!

I've added the method get_file_name to the ExcelView in analogy to
get_queryset which is inherited by View. I need this flexibility for one
of my projects. Should I push it to your repository?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1
.

[philippze]

Hi! Yes, of course, there should be a test.
However, there are no tests at all for the ExcelView class yet.
I'm thinking of also adding some non-trivial extensions.
Only if I do that, I'll write tests.
Philipp

[bitterjug]

LOL! Of course, I only tested the ColSpec bit.
I've been talking with a colleague about mashing it up with her spreadsheet
view, which is better tested and more robustly conceived.
Check this out: https://github.com/birdsarah/django-spreadsheetresponsemixin

I consider the ColSpec to be the real innivation of my library and hacked
the view bit on later as part of a project I was using it in.
Maybe the answer is to offer Col and Colspec as a separate package...

On Mon, Oct 14, 2013 at 10:47 AM, Philipp Zedler
[email protected]:

Hi! Yes, of course, there should be a test.
However, there are no tests at all for the ExcelView class yet.
I'm thinking of also adding some non-trivial extensions.
Only if I do that, I'll write tests.
Philipp

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-26245578
.

[philippze]

I've pushed a tiny bit of code for the case you want to include it.

Sounds good to use the well-tested view. However, before you extend your module: Do you have a good reason, why you don't use the import-export module?
https://github.com/bmihelac/django-import-export
I have a very bad reason: I have do cope with a Django1.3 installation.

[bitterjug]

Yeah, I spotted this recently and I really like the sound of tablib.
Our problem this week is openpyxl eating all our memory on import. Sigh

On Tue, Oct 15, 2013 at 8:47 PM, Philipp Zedler [email protected]:

I've pushed a tiny bit of code for the case you want to include it.

Sounds good to use the well-tested view. However, before you extend your
module: Do you have a good reason, why you don't use the import-export
module?
https://github.com/bmihelac/django-import-export
I have a very bad reason: I have do cope with a Django1.3 installation.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-26366166
.