Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No icon rendered if using squares="true" #13

Open
mainnet-pat opened this issue Sep 26, 2024 · 1 comment
Open

No icon rendered if using squares="true" #13

mainnet-pat opened this issue Sep 26, 2024 · 1 comment

Comments

@mainnet-pat
Copy link

It seems to be explicitly disabling the rendering of the icon slot by setting its display/visibility to none/hidden.

What is the rationale for this? I've tried to work this around and the qr-code is being recognized just fine with squares and icon displayed.

@mainnet-pat mainnet-pat changed the title No icon rendered if using "squares"=true No icon rendered if using squares="true" Sep 26, 2024
@rnbrady
Copy link

rnbrady commented Jan 7, 2025

Setting squares="true" also ignores color settings in favor of black and white so perhaps the intent was to maximise readability through contrast and removal of rounding, masking, icons, animation, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants