Homesets are not "personal" when they are detected two times (1x personal, 1x non-personal)

[rfc2822]

Problem scope

• I'm sure that this is a DAVx⁵ problem.

App version

• I'm using the latest available DAVx⁵ version.

Android version and device/firmware type

No response

Steps to reproduce

Create a DAVx5 account with a service that lists home-sets under multiple principals (e.g. mailbox.org). URL hierarchy:

• the user principal is something like /users/3, which contains both
  • a /carddav / /caldav homeset
  • group memberships in /principals/groups/0 (display name "Addressbooks")
  • and /principals/groups/1(display name "Standardgrouppe").

Actual result

DAVx5 queries the group principals, which again contain the /carddav / /caldav homeset. So the homeset is first detected as personal homeset (directly within the user principal), but then overwritten as non-personal homeset (from the group principals).

Expected result

If a home-set is detected as both personal and non-personal, it should be treated as personal.

Further info

No response

[rfc2822]

I think it should be possible to consequently query URLs only once.

1. The personal (as in level=0) collection will always be detected first, and then added to "already queried".
2. When the homeset is detected again in a higher recursion (level>0), it's already processed and won't be updated with personal=0.

However I'm afraid that it won't be possible "easily". Maybe it's a good time to further refactor the CollectionListRefresher.

@sunkup Can you start with reproducing the issue? And then see how a solution could look like.

[sunkup]

I can reproduce and confirm the problem. A very simple solution could be to insert the homeset only if it does not exist already. That works as expected for me.

val existing = homeSetRepository.getByHomesetUrl(service.id, resolvedHomeSetUrl.toString()) != null
if (!existing) {
    logger.fine("Homeset ${service.id}/$resolvedHomeSetUrl does not exist; inserting now")
    homeSetRepository.insertOrUpdateByUrl(
        HomeSet(0, service.id, personal, resolvedHomeSetUrl)
    )
} else
    logger.fine("Homeset ${service.id}/$resolvedHomeSetUrl exists already; not updating")

[rfc2822]

But would that work in the case that:

1. There's an old homeset (let's say with an old display name) in the database.
2. On level 0, this homeset is not detected (because it's not a personal one, but of some member group).
3. Then at level 1 or 2, the homeset is detected. Now it checks whether it's already existing, and it is.
4. So it won't be updated and the display name stays outdated.

I think the basic approach should work, but maybe existing shouldn't be derived from the database, but from whether this URL has already been fetched during this service detection. This is what I meant with "consequently query URLs only once".

[sunkup]

True, when checking against the database we won't update the homesets anymore at all! We would only want to check whether they have been fetched already, as you say.

if (!alreadyFetched.contains(resolvedHomeSetUrl)) {
    homeSetRepository.insertOrUpdateByUrl(
        HomeSet(0, service.id, personal, resolvedHomeSetUrl)
    )
    alreadyFetched += resolvedHomeSetUrl
}