Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open-source intro page default "don't remind for 1 month" does nothing #1275

Closed
rfc2822 opened this issue Jan 28, 2025 · 1 comment · Fixed by #1287
Closed

Open-source intro page default "don't remind for 1 month" does nothing #1275

rfc2822 opened this issue Jan 28, 2025 · 1 comment · Fixed by #1287
Assignees
Labels
bug Something isn't working

Comments

@rfc2822
Copy link
Member

rfc2822 commented Jan 28, 2025

Steps to reproduce:

  1. Uninstall DAVx5 (davx5-ose)
  2. Install again
  3. Go through all intro pages. Check all "Do not show anymore", except for the open-source page.
  4. Open-source page appears with default: Don't remind me for 1 month.
  5. Click Continue.
  6. Terminate DAVx5 in tasks manager.
  7. Open DAVx5 again.

Expected result:

Shouldn't remind for 1 month.

Actual result:

Open-source reminder shows again.

Further info:

Doesn't show again when I select "3 months". I assume that the default value isn't written to the settings backend when it's not clicked.

@rfc2822 rfc2822 added the bug Something isn't working label Jan 28, 2025
@sunkup
Copy link
Member

sunkup commented Jan 28, 2025

Yeah, I just noticed it too 👍

@sunkup sunkup moved this from Todo to In Review in DAVx⁵ Releases Jan 29, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in DAVx⁵ Releases Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
2 participants