Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalDataStore: reusable method to acquire content provider #1271

Closed
rfc2822 opened this issue Jan 28, 2025 · 0 comments · Fixed by #1272
Closed

LocalDataStore: reusable method to acquire content provider #1271

rfc2822 opened this issue Jan 28, 2025 · 0 comments · Fixed by #1272
Assignees
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Jan 28, 2025

Currently, the content provider for a LocalDataStore is acquired by the code that uses it, namely Syncer.

However there will be multiple locations where acquiring the content provider is needed:

So acquiring the content provider should be in a reusable class that is responsible to do so, possibly as LocalDataStore.acquireProvider(). This will probably also require to move the authority from the Syncer to the LocalDataStore.

@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jan 28, 2025
@rfc2822 rfc2822 self-assigned this Jan 28, 2025
@sunkup sunkup moved this from Todo to In Review in DAVx⁵ Releases Jan 29, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in DAVx⁵ Releases Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant