DB: use @StringDef to annotate possible service and collection types

[rfc2822]

We should use @StringDef to mark possible values of

• Collection.type
• Service.type
• maybe other values in these or other tables that have fixed possible values.

[sunkup]

We should use @StringRes to mark possible values of

• Collection.type

• Service.type

• maybe other values in these or other tables that have fixed possible values.

Umm, I don't understand this.

According to the android dev reference on @StringRes we use that annotation to "Denote that an integer parameter, field or method return value is expected to be a String resource reference (e.g. android.R.string.ok)".

The properties Collection.type and Service.type store strings only though, not integers?

[ArnyminerZ]

Why are we even storing strings in the first place? Shouldn't we simply migrate to enum classes?

[ArnyminerZ]

Umm, I don't understand this.

I think it is a typo, what Ricki is referring to is StringDef.

[rfc2822]

I think it is a typo, what Ricki is referring to is StringDef.

Yes sorry. Changed accordingly.