Invalid ZoneOffset when syncing in Persian language

[MohammadFakhraee]

When setting phone language to "fa" (Which is for Iran language), DAVx5 shows notification with Invalid ID for ZoneOffset, non numeric characters found: +۰۳۲۵۴۴ message every time I press sync button.

Steps to reproduce:

1. set davx5 language to Persian (فارسی) with/or "fa" locale.
2. Add an event with Etar calendar application. (it might be produced with other applications, but I tested this app so far). Make sure the event is not an AllDay event, otherwise the bug won't produce.
3. Come back to DAVx5 application and hit sync button.

This is the bug I get:

j$.time.d: Invalid ID for ZoneOffset, non numeric characters found: +۰۳۲۵۴۴
	at j$.time.ZoneOffset.R(Unknown Source:83)
	at j$.time.ZoneOffset.of(Unknown Source:75)
	at net.fortuna.ical4j.model.property.TzOffsetFrom.setValue(TzOffsetFrom.java:3)
	at net.fortuna.ical4j.model.property.TzOffsetFrom.<init>(TzOffsetFrom.java:5)
	at net.fortuna.ical4j.model.property.TzOffsetFrom$Factory.createProperty(TzOffsetFrom.java:3)
	at net.fortuna.ical4j.model.property.TzOffsetFrom$Factory.createProperty(TzOffsetFrom.java:2)
	at net.fortuna.ical4j.model.Property.copy(Property.java:21)
	at net.fortuna.ical4j.model.PropertyList.<init>(PropertyList.java:5)
	at net.fortuna.ical4j.model.Component.copy(Component.java:5)
	at net.fortuna.ical4j.model.ComponentList.<init>(ComponentList.java:5)
	at net.fortuna.ical4j.model.Component.copy(Component.java:12)
	at at.bitfire.ical4android.ICalendar$Companion.minifyVTimeZone(ICalendar.kt:6)
	at at.bitfire.ical4android.Event.write(Event.kt:439)
	at at.bitfire.davdroid.syncadapter.CalendarSyncManager$generateUpload$1.invoke(CalendarSyncManager.kt:7)
	at at.bitfire.davdroid.syncadapter.CalendarSyncManager$generateUpload$1.invoke(CalendarSyncManager.kt:1)

Here is also the debug report:

davx5-debug.zip

[ArnyminerZ]

I can't manage to reproduce. Steps followed:

1. Add a remote collection to DAVx⁵.
2. Set phone language to Persian.
3. Create an event with the default parameters from Etar.
4. Synchronize from DAVx⁵.

Please, can you give more details on how to reproduce? Also, please, report from davx5-ose when it's related to DAVx⁵.

[MohammadFakhraee]

Hi, firstly thanks for your answer and your amazing job on DAVx5.

Have you checked the AllDay Switch button? Because if you did, the error won't reproduce. The error is just producible if you set start and end time.

However I've figured out this error is not thrown in a few cases (which I couldn't find out why). But here is steps I made to produce the error:

1. Set event with shown parameters:
   

2. Change phone language to Persian in settings:
   

3. Press sync button inside DAVx5:
   

4. Sync in progress:
   

5. The error is shown in notification center:
   

After I debugged I've figured out it is happening inside ical4android module which uses ical4j library which returns a TimeZone object that holds Persian digits (not ASCII). I tried searching in ical4j issues and I found an interesting issue that @rfc2822 had opened here.

So how can I solve this issue inside DAVx5? Should I replace every Persian digit I see in TimeZone object with ASCII? Do you have any suggestions?

[MohammadFakhraee]

You can also see same numbers with different digits in offset which will return to the caller:

[rfc2822]

Hi,

Is it possible that the iCalendar that should be synced is broken and contains Arabic numbers, for instance because it was generated by a version of DAVx5 that used the old ical4j that generated broken VTIMEZONEs? In this case, only removing the VTIMEZONEs (rewrite the affected events, for instance with another client) or to totally delete/re-create them would help.

Otherwise, we'd need steps to reproduce the problem. It would be especially important to know whether the current DAVx⁵ version generates those invalid iCalendars or whether it's just about parsing.

[MohammadFakhraee]

Hi,
Thanks for your response. I checked the iCalendar and it didn't contain any Persian digits. Versions I'm currently checking with:

• DAVx5: 4.3-alpha.1 (commit: 62617a2)
• ical4j: 3.2.5 (also tested with 3.2.8)

I'm pretty sure steps I've mentioned will reproduce the problem. But there are some cases in which the problem won't occur:

1. Changing locale from DAVx5 Settings -> Select language section does not reproduce the bug. The solution you used to change application's locale, does not take affect in the entire app. So please change locale from device setting.
2. Some virtual devices do not support Persian language. Even though you're setting Persian as default, but the system language won't change. Please make sure virtual device you're using supports Persian language correctly.

If you search for class ZoneOffsetAdapter which is part of ical4j library, you'd see its toString is overridden. Inside toString method you can see String.format on line 32 and 34. The system generates formatted string based on locale (which is Persian/Arabic) and contains Persian/Arabic digits.

[rfc2822]

Ok so this seems to be a problem of ical4j. Please follow up there too: ical4j/ical4j#458

[MohammadFakhraee]

I'm greatly thankful to you guys. You're doing such a great job in DAVx5. I commented on the issue of ical4j.

[MohammadFakhraee]

Thanks a lot to DAVx5 team, specially @rfc2822 and @ArnyminerZ for their great support.

For those who might have the same problem, you can keep up with issue discussed here: ical4j/ical4j#458.