Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis updates #5

Closed
junderw opened this issue Dec 15, 2017 · 11 comments
Closed

Travis updates #5

junderw opened this issue Dec 15, 2017 · 11 comments
Assignees
Labels

Comments

@junderw
Copy link
Member

junderw commented Dec 15, 2017

@dcousens I noticed the builds were failing for travis on Node 4 and 5.

Default node when installing apt on Ubuntu 16.04 is v6

Which is already getting pretty old.
What are your thoughts on removing v4 and v5 from the supported versions?

@dcousens
Copy link
Contributor

https://github.com/nodejs/Release#release-schedule

I say we wait until the EOL? Then we can roll out across the entire organization?
April 2018.

@junderw
Copy link
Member Author

junderw commented Dec 15, 2017

Well, for now, until we ES5-ify bech32 and bolt11, those Travis tests will fail every time.

idk how Travis works for OSS, but it seems like a waste of processing time.

@dcousens
Copy link
Contributor

@junderw 14 days to EOL for 4.0.0 (and 5.0.0).
Feel free to remove from .travis.

It'd be good to get a PR ready for each repository under the organization and amend the package.json files throughout.

@junderw
Copy link
Member Author

junderw commented Apr 16, 2018

oh boy! haha.

I'll take some time later this week.

Here's a list of all the repos, please edit this message to remove any repos we won't need to update. (github.io comes to mind)

bech32
bip174
bip21
bip32
bip32-utils
bip32-wallet
bip38
bip39
bip44-constants
bip65
bip66
bip68
bip69
bitcoin-ops
bitcoinjs-lib
bitcoinjs-message
bitcoinjs.github.io
blkdat-stream
bolt11
bs58check
coinselect
indexd
merkle-lib
minimaldata
playground
private-bitcoin
pushdata-bitcoin
safe-transaction
tif
utxo
varuint-bitcoin
wif

@dcousens
Copy link
Contributor

That's not including the crypto-browserify repos that we will need to do too lol. But they are less pressing I suppose

@dcousens
Copy link
Contributor

dcousens commented Apr 16, 2018

@calvinmetcalf @fanatid how proactive do we want to be here?

@dcousens
Copy link
Contributor

And cryptocoinjs

@junderw
Copy link
Member Author

junderw commented Apr 16, 2018

hmmmm................................

I could try to make a bash script that will generate tons of pull requests...

@dcousens dcousens reopened this Nov 23, 2018
@dcousens
Copy link
Contributor

dcousens commented Nov 23, 2018

@junderw can you make an issue for the "organization" batch update of travis to the main repo?
(then close this)

@dcousens dcousens assigned junderw and unassigned dcousens Nov 23, 2018
@dcousens dcousens changed the title Move to NodeJS >=v6 Travis updates Nov 23, 2018
@junderw
Copy link
Member Author

junderw commented Nov 23, 2018

ok

@junderw
Copy link
Member Author

junderw commented Nov 23, 2018

bitcoinjs/bitcoinjs-lib#1266

Made a central issue.

@junderw junderw closed this as completed Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants