Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lightning crate to anything over 0.0.17 when available #131

Closed
sr-gi opened this issue Oct 6, 2023 · 3 comments
Closed

Update lightning crate to anything over 0.0.17 when available #131

sr-gi opened this issue Oct 6, 2023 · 3 comments
Labels
feature New feature or request good first issue Good for newcomers Medium Priority
Milestone

Comments

@sr-gi
Copy link
Member

sr-gi commented Oct 6, 2023

rust-lightning just merged a way to build Features<T> from a BE byte vector.

Update the dependency when the release becomes available (possibly in ~2/3 months, given they just released) so we can update our CLN feature parsing:

Ref: lightningdevkit/rust-lightning@2b1d693

@sr-gi sr-gi added the feature New feature or request label Oct 6, 2023
@carlaKC carlaKC added this to the V1 Minor Improvements milestone Oct 11, 2023
@sr-gi sr-gi changed the title Update lightning create to anything over 0.0.17 when available Update lightning crate to anything over 0.0.17 when available Oct 23, 2023
@carlaKC carlaKC modified the milestones: V1 Minor Improvements, V3 Mar 27, 2024
@carlaKC carlaKC added good first issue Good for newcomers help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Jul 8, 2024
@mubarak23
Copy link

@carlaKC can you give more context to this. i will like to work on it

@carlaKC
Copy link
Contributor

carlaKC commented Oct 7, 2024

See comment inline, we can update to use LDK's from_be_bytes

@carlaKC
Copy link
Contributor

carlaKC commented Jan 9, 2025

We updated to 17 a while ago and from_be_bytes was added in #209.

@carlaKC carlaKC closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers Medium Priority
Projects
None yet
Development

No branches or pull requests

3 participants