Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize URL Building Using urlBuilders Utility #327

Closed
coderabbitai bot opened this issue Dec 10, 2024 · 0 comments · Fixed by #341
Closed

Standardize URL Building Using urlBuilders Utility #327

coderabbitai bot opened this issue Dec 10, 2024 · 0 comments · Fixed by #341
Assignees
@AndlerRL @sheriffjimoh
Labels
difficulty:easy Issues that are easy to solve. enhancement New feature or request

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

There are inconsistencies in how URLs are constructed across the codebase.

Files using direct string concatenation:

  • apps/masterbots.ai/components/layout/header/user-menu.tsx
  • apps/masterbots.ai/components/layout/profile/profile-page-sidebar.tsx
  • apps/masterbots.ai/components/layout/sidebar/profile-sidebar.tsx
  • apps/masterbots.ai/lib/hooks/use-sidebar.tsx
  • apps/masterbots.ai/lib/threads.ts

Files using the urlBuilders utility:

  • sidebar-link.tsx
  • browse-list-item.tsx
  • chat-accordion.tsx

To improve maintainability and consistency, all URL construction should utilize the urlBuilders utility.

Backlinks:

@AndlerRL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndlerRL AndlerRL

@sheriffjimoh sheriffjimoh

Labels
difficulty:easy Issues that are easy to solve. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardize url building using urlbuilders utility bitcashorg/masterbots
2 participants
@AndlerRL @sheriffjimoh