Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 lsp-proxy ignores --config-path and BIOME_CONFIG_PATH. #4834

Open
1 task done
somename-123 opened this issue Jan 4, 2025 · 0 comments
Open
1 task done

🐛 lsp-proxy ignores --config-path and BIOME_CONFIG_PATH. #4834

somename-123 opened this issue Jan 4, 2025 · 0 comments
Labels
S-Needs triage Status: this issue needs to be triaged

Comments

@somename-123
Copy link

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-kitty"
  JS_RUNTIME_VERSION:           unset
  JS_RUNTIME_NAME:              unset
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

I use Helix editor.

Biome DOES respect biome.json placed in the workspace root and everything works flawlessly. Biome is the only language server set for JavaScript.

Biome IGNORES biome.json when used with --config-path "/path/to/dir" or --config-path "/path/to/biome.json" or BIOME_CONFIG_PATH set via:

[language-server]
biome = { command = "biome", args = ["lsp-proxy", "--config-path", "/path/to/biome.json"] }

or

[language-server.biome]
command = "biome"
args = ["lsp-proxy"]
environment = { "BIOME_CONFIG_PATH" = "/path/to/biome.json" }

Also, running biome lsp-proxy --config-path "/does/not/exist/biome.json" in terminal does not produce any errors.

Steps to reproduce:

  1. Use the latest version of Helix and the latest version of Biome.
  2. Close helix.
  3. Use the following languages.toml:
[language-server]
biome = { command = "biome", args = ["lsp-proxy", "--config-path", "/path/to/biome.json"] }

[[language]]
name = "javascript"
language-servers = [ "biome" ]
auto-format = true
  1. Start helix.
  2. Try to format a JavaScript file with :format or otherwise; Biome will use its default configuration.
  3. Running :lsp-restart has no effect.

Expected result

It should use the configuration file specified by --config-path and possibly throw an error if it does not exist.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@somename-123 somename-123 added the S-Needs triage Status: this issue needs to be triaged label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Needs triage Status: this issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant