📎 Implement useObjectShorthand

[arendjr]

Description

Port the object-shorthand rule from eslint.

[scarf005]

Hi, I'm interested on opening a PR.

[ematipico]

@scarf005 I assigned the issue to you

[dy0gu]

Hi there @scarf005, sorry to bother but do you have any updates on this? I also accept pointers on how to get started doing it myself if the implementation is not too complex!

object-shorthand and no-floating-promisses are 2 of the rules I miss the most in the midst of all the awesomeness Biome provides.

Since I'm not getting the latter (blocked by #3187), I'd love to help speed this one up just for me personally! 😁

[dyc3]

Since we haven't heard from @scarf005 in a while, I'll go ahead and reassign this to @dy0gu.

[dy0gu]

Hi again, I was wondering if this has to be an exact port of the eslint rule? One team I work with prefers using the old syntax everywhere, instead of the newer ECMAScript 6 form.

Do you think it would make sense to create a useConsistentObjectShorthand or useConsistentObjectDefinition instead? With a syntax option to pick between the newer ECMAScript and the old way.

[ematipico]

Probably better to use a "neutral" name (second suggestion). You could follow the same naming convention of https://biomejs.dev/linter/rules/use-consistent-array-type/#options