Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Body of the function is formatted with the same indent as previous line #4202

Closed
1 task done
tylerbutler opened this issue Oct 7, 2024 · 1 comment · Fixed by #4811
Closed
1 task done

📝 Body of the function is formatted with the same indent as previous line #4202

tylerbutler opened this issue Oct 7, 2024 · 1 comment · Fixed by #4811
Assignees
@mdm317
Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@tylerbutler
Copy link

Environment information

CLI:
  Version:                      1.9.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.20.4"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.15.8"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              true
  Organize imports disabled:    true
  VCS disabled:                 false

Formatter:
  Format with errors:           true
  Indent style:                 Tab
  Indent width:                 2
  Line ending:                  Lf
  Line width:                   95
  Attribute position:           Auto
  Bracket spacing:              BracketSpacing(true)
  Ignore:                       ["**/dist/**", "**/lib/**"]
  Include:                      []

JavaScript Formatter:
  Enabled:                      false
  JSX quote style:              Double
  Quote properties:             Preserve
  Trailing commas:              All
  Semicolons:                   Always
  Arrow parentheses:            Always
  Bracket spacing:              BracketSpacing(true)
  Bracket same line:            false
  Quote style:                  Double
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Attribute position:           unset

JSON Formatter:
  Enabled:                      false
  Indent style:                 Tab
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Trailing Commas:              unset

CSS Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Quote style:                  Double

GraphQL Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Bracket spacing:              unset
  Quote style:                  unset

Workspace:
  Open Documents:               0

Configuration

{
	"$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
	"vcs": {
		"enabled": true,
		"clientKind": "git",
		"root": ".",
		"useIgnoreFile": true,
		"defaultBranch": "main"
	},
	"formatter": {
		"enabled": true,
		"ignore": ["**/dist/**", "**/lib/**"],
		"formatWithErrors": true,
		"indentStyle": "tab",
		"lineWidth": 95,
		"lineEnding": "lf"
	},
	"javascript": {
		"formatter": {
			"arrowParentheses": "always",
			"jsxQuoteStyle": "double",
			"semicolons": "always",
			"trailingCommas": "all",
			"quoteProperties": "preserve",
			"quoteStyle": "double",
			"bracketSpacing": true
		}
	},
	"json": {
		"formatter": {
			"indentStyle": "tab"
		}
	}
}

Playground link

https://biomejs.dev/playground/?quoteProperties=preserve&trailingCommas=none&code=ZABlAHMAYwByAGkAYgBlACgAIgB0AGUAcwB0ACIALAAgACgAKQAgAD0APgAgAHsACgBpAHQAKAAiAEMAbABpAGUAbgB0ACAAMwAgAHMAaABvAHUAbABkACAAdwBhAGkAdAAgAGYAbwByACAAYwBsAGkAZQBuAHQAIAAyACgAdwBoAGkAYwBoACAAZwBvAHQAIABkAGkAcwBjAG8AbgBuAGUAYwB0AGUAZAAgAHcAaQB0AGgAbwB1AHQAIABzAGUAbgBkAGkAbgBnACAAYQBuAHkAIABvAHAAcwApACAAdABvACAAbABlAGEAdgBlACAAIgAgACsACgAJAAkAIgB3AGgAZQBuACAAYwBsAGkAZQBuAHQAIAAyACAAYQBsAHIAZQBhAGQAeQAgAHcAYQBpAHQAZQBkACAAbwBuACAAYwBsAGkAZQBuAHQAIAAxACIALAAgAGEAcwB5AG4AYwAgACgAKQAgAD0APgAgAHsACgAgACAAYwBvAG4AcwB0ACAAYgBsAG8AYwBrAEIAZQBnAGkAbgAgAD0AIAAwADsACgAgACAALwAvACAALgAuAC4AIABtAG8AcgBlACAAYwBvAGQAZQAgAC4ALgAuAAoACQB9ACkAOwAKAH0AKQA7AA%3D%3D

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@tylerbutler tylerbutler mentioned this issue Oct 7, 2024
Merged
@ematipico ematipico added A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug L-JavaScript Language: JavaScript and super languages labels Oct 7, 2024
@mdm317
Copy link
Contributor

mdm317 commented Dec 27, 2024

I’d like to work on this issue.

@mdm317 mdm317 mentioned this issue Jan 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdm317 mdm317

Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(js_formatter): updated the is_test_call_expression function to match prettier mdm317/biome
3 participants
@tylerbutler @ematipico @mdm317