Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues from downloading only the rdf.yaml file #442

Open
FynnBe opened this issue Jan 23, 2025 · 1 comment
Open

Issues from downloading only the rdf.yaml file #442

FynnBe opened this issue Jan 23, 2025 · 1 comment

Comments

@FynnBe
Copy link
Member

FynnBe commented Jan 23, 2025

As the rdf.yaml files we host contain relative paths (or rather 'relative URLs') only downloading an rdf.yaml (and not the packaged zip).

We should consider hosting rdf.yaml files with URLs in them.

For now I think we should add a warning to the downloader where a download link to the source rdf.yaml file is offered.
something like
(for reference only; the source RDF file contains relative file paths that cannot be resolved when only downloading this file. We recommend to download a package that contains additional files like neural network weights)

Current downloader GUI with link to "source RDF file":

Image

Thanks @pattonw for reporting a related issue:

Ah, ok. Thanks for the info. This makes a lot of sense. I didn't realize the rdf contained only relative paths.

As for how I got the rdf:
I just clicked on the model I wanted: affable-shark, hit the little download button, and clicked the first link source RDF file

I was given the default name of "rdf.yaml" but I was testing a few different models so I renamed it to "nuclei.yaml" for my convenience not realizing that the name was important.

Originally posted by @pattonw in #449

@FynnBe
Copy link
Member Author

FynnBe commented Jan 23, 2025

actually I could also implement resolving relate paths in bioimageio.core.
The collection base URL can be an environment variable (with our curent S3 as default) and id and version are enough to find the RDF 'root'...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant