Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas versions should be pinned to be below v1 #117

Open
fedarko opened this issue Feb 21, 2020 · 3 comments
Open

Pandas versions should be pinned to be below v1 #117

fedarko opened this issue Feb 21, 2020 · 3 comments
Labels
dependencies tensorflow tensorflow tensorflow tensorflow tensorflow

Comments

@fedarko
Copy link
Collaborator

fedarko commented Feb 21, 2020

This is causing problems with the standalone songbird installation instructions. Easiest solution is just modifying this part of the README to specify the pandas version, ideal solution is modifying the setup.py/conda requirements/conda-forge dependencies to enforce this.

@fedarko fedarko added the dependencies tensorflow tensorflow tensorflow tensorflow tensorflow label Feb 21, 2020
@ElDeveloper
Copy link
Member

This might not work well with newer versions of QIIME2 since the move to 1.0 is happening (as far as I can tell) as of the next version.

@mortonjt
Copy link
Collaborator

Agree @ElDeveloper , we will need a better solution for that.

Not clear to me where the dep issue arise from (other than the one spotted in biom). Will need to dig into this.

@fedarko
Copy link
Collaborator Author

fedarko commented Feb 21, 2020

Oh dang, in the February 2020 release? I think that might break a few third-party plugins -- I know Qurro at least will also explode.

@mortonjt I think the problem is due to the use of SparseDataFrame / SparseSeries rather than the new-style pandas sparse data structures -- this is why Qurro will explode on pandas 1, and an error about SparseSeries was what broke Songbird on barnacle for @vjcantu and I today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies tensorflow tensorflow tensorflow tensorflow tensorflow
Projects
None yet
Development

No branches or pull requests

3 participants