Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BIOM version required #272

Closed
fedarko opened this issue Feb 15, 2020 · 0 comments
Closed

Update BIOM version required #272

fedarko opened this issue Feb 15, 2020 · 0 comments
Assignees
@fedarko
Labels
external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally

Comments

@fedarko
Copy link
Collaborator

fedarko commented Feb 15, 2020 •
edited
Loading

Supporting >= 2.1.8 will mean no more python3.5 support, so we'll need to update the changelog and setup.py (python_requires) accordingly.

However this does get us some snazzy new features, including no need to explicitly use SparseDataFrames I think (since table.to_dataframe(dense=False) should now work as intended, due to biocore/biom-format#808 being addressed).

Prooobably related to #271. edit: also definitely related to #258, i think
@fedarko fedarko added the external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally label Feb 15, 2020
@fedarko fedarko self-assigned this Feb 15, 2020
@fedarko fedarko mentioned this issue Feb 15, 2020
Closed
fedarko added a commit that referenced this issue Feb 25, 2020
@fedarko
Merge pull request #276 from antgonza/fix-272
d18f769 
fix #272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedarko fedarko

Labels
external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fedarko