Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support drawing origin for barplot length-scaling #300

Open
fedarko opened this issue Aug 5, 2020 · 0 comments
Open

Support drawing origin for barplot length-scaling #300

fedarko opened this issue Aug 5, 2020 · 0 comments

Comments

@fedarko
Copy link
Collaborator

fedarko commented Aug 5, 2020

Continuation of #201. Currently, the length-scaling code doesn't take into account the sign of numeric values: all that's considered are the min and max values.

However, it would be nice to be able to have each bar point in different directions based on its sign -- see e.g. this sketch (definitely not to scale but the idea should be close enough)

fig

This could be particularly useful for things like feature differentials, where we'd want +3 and -3 to be clearly symmetric.

@fedarko fedarko changed the title Support drawing "origin" for barplot layers Support drawing origin for barplot length-scaling Aug 5, 2020
fedarko added a commit to fedarko/empress that referenced this issue Aug 6, 2020
(biocore#300 is now documented on GitHub, so we can get to it eventually)
@fedarko fedarko self-assigned this Aug 17, 2020
@kwcantrell kwcantrell added this to the Third Beta Release milestone Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants