Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save extra work of cos/sin calls #225

Open
fedarko opened this issue Jun 29, 2020 · 0 comments
Open

Save extra work of cos/sin calls #225

fedarko opened this issue Jun 29, 2020 · 0 comments
Labels
good first issue performance refactoring Use best practices or improve the usage of public APIs
Milestone
1.1 Release

Comments

@fedarko
Copy link
Collaborator

fedarko commented Jun 29, 2020

@wasade pointed this out about this JS code -- there are 8 calls to cos or sin within this block, but we could cut this down to just 4 calls by saving the value of each call for later in the block.

From some more digging, this also impacts this JS code for drawing thick lines, as well as this python code.
@fedarko fedarko added performance refactoring Use best practices or improve the usage of public APIs labels Jun 29, 2020
@ElDeveloper ElDeveloper added this to the Second Beta Release milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue performance refactoring Use best practices or improve the usage of public APIs
Projects
None yet
Milestone
1.1 Release
Development

No branches or pull requests
2 participants
@ElDeveloper @fedarko