Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using 0-indexing for the tree indices #223

Open
fedarko opened this issue Jun 29, 2020 · 0 comments
Open

Using 0-indexing for the tree indices #223

fedarko opened this issue Jun 29, 2020 · 0 comments
Labels
refactoring Use best practices or improve the usage of public APIs

Comments

@fedarko
Copy link
Collaborator

fedarko commented Jun 29, 2020 •
edited
Loading

Suggestion from @dhakim87 during code review today. Indices are currently 1-indexed to resemble the original BP paper.
@fedarko fedarko added the refactoring Use best practices or improve the usage of public APIs label Jun 29, 2020
@fedarko fedarko mentioned this issue Jul 8, 2020
Merged
@kwcantrell kwcantrell mentioned this issue Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Use best practices or improve the usage of public APIs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fedarko