Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move thickenSameSampleLines() into shader #214

Open
kwcantrell opened this issue Jun 26, 2020 · 1 comment
Open

Move thickenSameSampleLines() into shader #214

kwcantrell opened this issue Jun 26, 2020 · 1 comment
Assignees
Milestone

Comments

@kwcantrell
Copy link
Collaborator

This is related to #190. Currently thick lines are computed on the cpu. However, this can be quite expensive on large trees (especially on the circular layout.

--

It's not within the scope of this PR, but redrawing the entire tree whenever nodes are selected/unselected seems like it could get costly with really large trees. Do you think it'd be worth opening an issue for, later on down the line, making this more efficient?

(If you expect redrawing the tree to be a fast operation even for large trees then no worries. Just looking out for any potential future bottlenecks.)

Originally posted by @fedarko in https://github.com/biocore/empress/pull/212/files

@ElDeveloper
Copy link
Member

Related to #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants