Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute test coverage and show in README #156

Open
fedarko opened this issue Apr 8, 2020 · 0 comments
Open

Compute test coverage and show in README #156

fedarko opened this issue Apr 8, 2020 · 0 comments

Comments

@fedarko
Copy link
Collaborator

fedarko commented Apr 8, 2020

This will help a lot with guiding us on what still needs to be tested.

In the python side of things this should be doable by just a few tweaks to how we install/run nosetests. In the JS side of things I think we'll need to make some changes, since qunit-puppeteer doesn't support getting code coverage out right now. Options for different test runners include:

Thanks @antgonza for the suggestion!

@fedarko fedarko self-assigned this Apr 8, 2020
@fedarko fedarko added the testing label Apr 8, 2020
fedarko added a commit to fedarko/empress that referenced this issue Apr 9, 2020
Basically replicates what I did a while back in
74d0f46 and
f84fa78 (with the slight change
that now the coverage package is installed in setup.py's test
requirements, which is a pretty nifty way to handle this).

Partial progress on biocore#156; still need to finagle things so that we
can get test coverage from the JS tests.
@fedarko fedarko added this to the Second Beta Release milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants