Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.14.10 - DI - 2D-mapping Total and Ring intensity maps and D-space maps are not showing right. #47

Open
rmadhura-iit opened this issue Jul 11, 2019 · 8 comments

Comments

@rmadhura-iit
Copy link

After the total and ring intensity maps are showing just one color, even after adjusting the scale. The intensities of these rings are quite different, in my case, so the heatmap should reflect these. This feature works fine for 1D
image

@grantnikseresht
Copy link
Contributor

Can you point me to the dataset you're using for this one? Are you manipulating the min and max intensities to adjust the scale?

This feature is working for me on Docker via lethocerus with Muscle X 1.14.11. The colorbar scaling will sometimes show as one color for large absolute numbers since the minimum of the scale is always zero, but this should work at higher minimum intensities. If you are noticing no changes to color at all or unexpected values, let me know.

@rmadhura-iit
Copy link
Author

rmadhura-iit commented Jul 17, 2019 via email

@grantnikseresht
Copy link
Contributor

Using the Bicuspid data you sent me, I generated a new HDF5 file automatically using Start=0 End=7 and Step Size=1 and the colors are showing normally. When I use the HDF file in calib, I'm getting all one color. I've also noticed that a baseline color is filled in to square off heat maps when they're not perfectly square / rectangular, so perhaps the step size / start / end scales are off.

You could try recreating the HDF5 file you've been using from calib or perhaps generating a new one with the same parameters through DI? I'll look into the differences between your hdf and the DI generated one in the meantime.

Screen Shot 2019-07-19 at 3 24 37 PM

Screen Shot 2019-07-19 at 3 25 05 PM

Screen Shot 2019-07-19 at 3 25 51 PM

@rmadhura-iit
Copy link
Author

rmadhura-iit commented Jul 22, 2019 via email

@rmadhura-iit
Copy link
Author

Is there any chance we are using a parameter from one of the headers on the HDFs to make this heatmap? Something like beamcurrent? That is usually a very small number (~100). We should check for this.

@grantnikseresht
Copy link
Contributor

I checked the HDF file and it seems like the X initial location and step size are positive but the final location is negative. This case is likely not going to work correctly in current versions of MuscleX.

Is this a detector configuration we need to be able to handle?

@rmadhura-iit
Copy link
Author

Well the X and Y motor positions are absolute positions reported from the motors. So the positions are what they are. But we are only using them to generate the grid here though, so I don't know if this needs to be fixed at the beamline?

@rmadhura-iit
Copy link
Author

So I put more thought into this. We need a way to make it work with motor positions we collect at the beamline. There is no way around it.

Why can we not use the absolute positions and ignore step size completely, when we are picking up an HDF file? It doesn't matter what the step size is. If we are using X and Y motor positions from the HDF file, step size need not be accounted for.

Does this help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants