Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Complete the Person component #3

Open
3 tasks
ianwalter opened this issue May 25, 2018 · 3 comments
Open
3 tasks

Complete the Person component #3

ianwalter opened this issue May 25, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@ianwalter
Copy link
Contributor

ianwalter commented May 25, 2018 •
edited
Loading

  • Display the person's data
  • Format the page to look like a profile page
  • Link to pages of related resources (if they exist)

⭐⭐
@ianwalter ianwalter added the enhancement New feature or request label May 25, 2018
sfrankian added a commit to sfrankian/force-vue-awakens that referenced this issue May 28, 2018
@sfrankian
Changed title of profile page from 'Person n' to name retrived from A…
db1d933 
…PI (issue binxhealth#3).
sfrankian added a commit to sfrankian/force-vue-awakens that referenced this issue May 28, 2018
@sfrankian
binxhealth#3 added person profile page. Still need to add links to re…
86154cb 
…lated resources
sfrankian added a commit to sfrankian/force-vue-awakens that referenced this issue May 28, 2018
@sfrankian
binxhealth#3 changed rendering of person component to only show vehic…
9c96db7 
…les if person has them
sfrankian added a commit to sfrankian/force-vue-awakens that referenced this issue May 28, 2018
@sfrankian
binxhealth#3 Finished (just need to write tests). Because planet/star…
0c2314a 
…ship components are not available, just linking to API for now.
sfrankian added a commit to sfrankian/force-vue-awakens that referenced this issue May 28, 2018
@sfrankian
binxhealth#3 - forgot to make homeworld a link.
b980b0c
sfrankian added a commit to sfrankian/force-vue-awakens that referenced this issue May 28, 2018
@sfrankian
Made person template conditionally render based on whether we have re…
cf8ee4f 
…sults in the datastore (binxhealth#3). Also added back in error handling for incorrect people path - relates to binxhealth#9.
@sfrankian sfrankian mentioned this issue May 29, 2018
Closed
@binxhealth binxhealth deleted a comment from sfrankian Apr 4, 2019
tomlovett added a commit to tomlovett/force-vue-awakens that referenced this issue Apr 9, 2019
@tomlovett
binxhealth#3 Complete Person component; attempt to query Person data
9be6a3b
@tyholland
Copy link

Completed the person profile with a back link to the page with all the people on it.
I didn't add links to other resources such as home planet and etc. But I can certainly create them if necessary.

Person.vue.zip

@alexkramer
Copy link
Member

@tyholland Thanks for the submission! Would you be able to push your changes to your fork and open a PR into this repo?

@tyholland
Copy link

tyholland commented Apr 16, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ianwalter @alexkramer @tyholland