New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider hardcoded format requires for client-side support #3

Open

aklos opened this issue Jun 25, 2018 · 0 comments

aklos commented Jun 25, 2018

First of all, thanks for this nice library. It works great server-side, but it doesn't support client-side because of the use of fs.

Is there any reason why it can't require the VRM formats like below?

const formats = [
	require('./diplomatic.js'),
	require('./gb-1903.js'),
	require('./gb-1932.js'),
	require('./gb-1963.js'),
	require('./gb-1983.js'),
	require('./gb-2001.js'),
	require('./military.js'),
	require('./ni-1903.js'),
	require('./ni-1966.js')
];

Discovering the formats dynamically is better, but the list of formats seems pretty static.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment