You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Court-scraper currently expects credentials for sites that require login to be placed in a yaml config. We need to add support for looking up creds in env vars in order to support wider automated test coverage via GitHub Actions, per the discussion on #143
For non-CAPTCHA login tests, we might be able to get away with a simple user/pass env var lookup such as COURT_SCRAPER_LOGIN_USER and COURT_SCRAPER_LOGIN_PASS.
The only hitch there is that it requires us to use the same user/pass for all sites, which may or may not be possible depending on factors out of our control (e.g. password length/complexity requirements).
A more complex alternative would be to check for env var-based creds in a way that allows for customization by place ID (basically mirroring the approach of config.yaml). For example, COURT_SCRAPER_GA_DEKALB_USER and COURT_SCRAPER_GA_DEKALB_PASS, if set, could take precedence over values found in the config.yaml file.
We could start with the simple approach and then pivot to something more complex if the need arises.
Either approach will likely require updates in court_scraper.config as well as in the Odyssey platform scraper (and perhaps elsewhere).
The text was updated successfully, but these errors were encountered:
Court-scraper currently expects credentials for sites that require login to be placed in a yaml config. We need to add support for looking up creds in env vars in order to support wider automated test coverage via GitHub Actions, per the discussion on #143
For non-CAPTCHA login tests, we might be able to get away with a simple user/pass env var lookup such as
COURT_SCRAPER_LOGIN_USER
andCOURT_SCRAPER_LOGIN_PASS
.The only hitch there is that it requires us to use the same user/pass for all sites, which may or may not be possible depending on factors out of our control (e.g. password length/complexity requirements).
A more complex alternative would be to check for env var-based creds in a way that allows for customization by place ID (basically mirroring the approach of config.yaml). For example,
COURT_SCRAPER_GA_DEKALB_USER
andCOURT_SCRAPER_GA_DEKALB_PASS
, if set, could take precedence over values found in the config.yaml file.We could start with the simple approach and then pivot to something more complex if the need arises.
Either approach will likely require updates in
court_scraper.config
as well as in the Odyssey platform scraper (and perhaps elsewhere).The text was updated successfully, but these errors were encountered: