Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store Operations- Rearrange folder structure, change file name for store metafields #752

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Store Operations- Rearrange folder structure, change file name for store metafields #752

merged 4 commits into from
Jan 16, 2025

Conversation

bc-andreadao
Copy link
Collaborator

@bc-andreadao bc-andreadao commented Jan 15, 2025 •
edited
Loading

Must merge at the same time as PR 1061(menu change) to prevent the current doc links from breaking

What changed?

  • Rename the product-store-metafields.mdx doc to store-metafields.mdx (not related to products)
  • Change the folder structure to match the IA (less confusion)

Release notes draft

N / A

Anything else?

@bc-andreadao bc-andreadao marked this pull request as ready for review January 15, 2025 23:45
github-actions[bot]
github-actions bot reviewed Jan 15, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

remark-lint

docs/storefront/graphql/multi-language-support.mdx|113 col 146| Link to /docs/store-operations/catalog/msf-international-enhancements/msf-international-enhancements is dead no-dead-urls remark-lint
docs/storefront/graphql/examples/products.mdx|18 col 189| Link to /docs/store-operations/catalog/msf-international-enhancements/msf-international-enhancements is dead no-dead-urls remark-lint

github-actions[bot]
github-actions bot reviewed Jan 16, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

remark-lint

docs/storefront/graphql/multi-language-support.mdx|113 col 124| Link to /docs/store-operations/catalog/msf-international-enhancements/overview is dead no-dead-urls remark-lint
docs/storefront/graphql/examples/products.mdx|18 col 167| Link to /docs/store-operations/catalog/msf-international-enhancements/overview is dead no-dead-urls remark-lint

bc-traciporter
bc-traciporter approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bc-andreadao bc-andreadao merged commit d318c87 into main Jan 16, 2025
3 checks passed
@bc-andreadao bc-andreadao deleted the ia-rearrangement branch January 16, 2025 19:23
@bc-andreadao bc-andreadao mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bc-traciporter bc-traciporter bc-traciporter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bc-andreadao @bc-traciporter