forked from rminnich/nix-os
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathPROCESS
88 lines (57 loc) · 2.55 KB
/
PROCESS
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
Contributers:
If you'd like to contribute to NIX the following process has been
created to simplify distributed development. Our process is heavily
influenced by the golang model which you can find at
http://golang.org/doc/contribute.html.
To be able to contribute you need to do three things.
1. Subscribe to the nix-dev mailing list
http://groups.google.com/group/nix-dev (all development
correspondance, including codereviews, goes here).
2. Ask to be added to the CONTRIBUTORS file on nix-dev. (this will
allow you to submit codereviews)
3. Set up mercurial to use the codereview plugin in
<nixhome>/sys/lib/codereview/codereview.py by adding the following
your .hg/hgrc :
[extensions] codereview = sys/lib/codereview/codereview.py
[codereview] server = codereview.appspot.com
[ui] username=blah@blah EOF
4. Submit patches using the following process
hg code-login # login to the codereview server with your google
account
# Make changes
# specify which changed files, who should review and why the change
# was made
# include the following in your change list:
# Reviewer: the person who is most qualified to judge your changes
# CC: other developers that may be interested in your changes.
# Description: is a one line summary of your change, prefixed by the
# affected file, followed by any more information needed to understand
# your changes.
# Files: A list of the files that constitute your changeset. Note
# that this list is finer grained than a mercurial commit and you should
# only include files relevant to your particular change.
hg change
# use the issue number from hg change to notify the other NIX
# developers on nix-dev of your change.
hg mail <number>
# You should then wait for the Reviewer you specified in hg change to
# acknowledge your changes with 'LGTM'(Looks Good To Me) or ask for
# further changes.
# If the reviewer asks for more changes, make the revelant changes and
# then resubmit by doing hg mail <number> again. You do not need
# to do another hg change.
# Once your changes are made the reviewer or someone with commit
# access will submit your change to the mail repository once it has been
# acknowledged with LGTM.
Submitters:
Submitters can test and submit patches from contributers using the
following steps:
# apply a patch from a submitted patch set
hg clpatch <number>
# if the patch is acknowledged with LGTM submit it
hg submit <number>
Repository maintanence:
Codereview uses the sync command to synchronize individual
repositories, instead of push and pull:
# synchronize your NIX repository with the main tree.
hg sync