You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@bhouston@oveddan Regarding the dynamic I/O here are the tricks I had to use in order to be able to identify them:
First I had to instantiate every single node with numInputs and numOutputs setted so I can get them from the Node instance, also had to initialize the customEvents and variables properties because otherwise some nodes were crashing:
Then I had to compare the Node instance which has the dynamic nodes already setted with the NodeSpec which doesn't have them so I can figure out if that Node has dynamic I/O. This only works for numeric cases
That's the reason I think the dynamic I/O specification is incomplete with just the numInputs/numOutputs configuration, I think we should be able to determine before the Node gets instantiated:
whether a Node can have dynamic I/O or not (this is currently doable with the configuration definition but only if the Node has a single case for each, ie. it's not possible to define a Node with n text inputs + n flow inputs)
which types will those sockets accept
and maybe which names do they accept (numeric, text...)
Right now this is a must not only to be able to provide a better logic for docs generation but for the visual editor to be able to recognize them as well
It would be great to have something like this in the NodeSpec:
Here is a comment from @aitorllj93 that is important to address: #201 (comment)
@bhouston @oveddan Regarding the dynamic I/O here are the tricks I had to use in order to be able to identify them:
First I had to instantiate every single node with numInputs and numOutputs setted so I can get them from the Node instance, also had to initialize the customEvents and variables properties because otherwise some nodes were crashing:
Then I had to compare the Node instance which has the dynamic nodes already setted with the NodeSpec which doesn't have them so I can figure out if that Node has dynamic I/O. This only works for numeric cases
That's the reason I think the dynamic I/O specification is incomplete with just the numInputs/numOutputs configuration, I think we should be able to determine before the Node gets instantiated:
Right now this is a must not only to be able to provide a better logic for docs generation but for the visual editor to be able to recognize them as well
It would be great to have something like this in the NodeSpec:
Or maybe considering the current NodeSpec implementation we can extend the inputs & outputs types to allow it:
And just query by the
isMultiple/isDynamic
(Idk how to name it) propIn order to use them inside the Node we could just get the "group" by the name and iterate over them:
The text was updated successfully, but these errors were encountered: