Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings as errors for test. #29

Open
mnaveedb opened this issue Oct 26, 2020 · 0 comments
Open

Add warnings as errors for test. #29

mnaveedb opened this issue Oct 26, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mnaveedb
Copy link
Collaborator

In CMAKE the warnings are enabled for the library but not for tests.

May be its might not be good idea to enable then in tests as well.
This can be done Line 15 Cmake : SET( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} .. adding -Werror -Wall -Wextra

and then we can remove the target_compile_options(finalmq PRIVATE -Werror -Wall -Wextra) which enable s them for the lib only

@mnaveedb mnaveedb added the enhancement New feature or request label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants