-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jsbundling + webpack #3343
Jsbundling + webpack #3343
Conversation
RAFCSS
JS
Autre
Questions
|
93a981f
to
193c4dc
Compare
193c4dc
to
09d5d9c
Compare
…treprises into jsbundling-webpack
…treprises into jsbundling-webpack
…g asset in production
… using nodejs engine >=v20
Ola, j'ai rien remarqué qui cloche au niveau fonctionnel ! Juste des trucs de style, mais peut-être liés à la MaJ du dsfr. C'est partie pour le jeu des 7 différences :
|
En effet, il manquait le css icons-communication du dsfr, qui résout l'icone manquante et probablement le reste des soucis par la même occasion |
# Conflicts: # config/initializers/content_security_policy.rb # doc/domain_model.pdf
|
Moi ça me semble tout bon :) Une mise en prod la semaine prochaine ? |
# Conflicts: # app/views/application/_head.html.haml # app/views/layouts/pages.html.haml # config/initializers/content_security_policy.rb # config/webpack/production.js # doc/domain_model.pdf # package.json # yarn.lock
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11093449 | Triggered | Generic Password | a336a57 | .circleci/config.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
-
Revoke and rotate the secret.
-
If possible, rewrite git history with
git commit --amend
andgit push --force
.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
p.object_src :none | ||
p.style_src :self, :unsafe_inline, 'https://fonts.googleapis.com' | ||
p.script_src :self, :blob, 'https://browser.sentry-cdn.com', 'sentry.io', 'stats.data.gouv.fr', 'https://stats.beta.gouv.fr/', 'https://cdn.jsdelivr.net/', 'https://www.googletagmanager.com/', 'https://www.googleadservices.com', 'https://googleads.g.doubleclick.net', 'https://www.google.com', 'www.pagespeed-mod.com' | ||
p.frame_src :self, 'stats.data.gouv.fr', 'https://stats.data.gouv.fr/', 'browser.sentry-cdn.com', 'https://cdn.jsdelivr.net/', 'https://bid.g.doubleclick.net', 'https://tube.nocturlab.fr', 'https://tpc.googlesyndication.com', 'https://www.youtube-nocookie.com' | ||
p.frame_src :self, 'stats.data.gouv.fr', 'stats.beta.gouv.fr', 'browser.sentry-cdn.com', 'https://cdn.jsdelivr.net/', 'https://bid.g.doubleclick.net', 'https://tube.nocturlab.fr', 'https://tpc.googlesyndication.com', 'https://www.youtube-nocookie.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on a encore besoin du stats.data.gouv.fr
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non mais on a deux trois csp qu'on peut virer, comme c'etait pas dans le conflit je me suis dit que l'allait faie une carte optimisation des csp
close #3342