Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsbundling + webpack #3343

Merged
merged 58 commits into from
Jun 6, 2024
Merged

Jsbundling + webpack #3343

merged 58 commits into from
Jun 6, 2024

Conversation

clairezed
Copy link
Collaborator

close #3342

@PiflY
Copy link
Collaborator

PiflY commented Feb 14, 2024

RAF

CSS

  • font non importées
  • remixicon cassé
  • dans la navbar "tutoriel" et "mon compte" ne sont plus alignés à droite
  • réinternaliser remixicon

JS

  • erreur en console Uncaught TypeError: Cannot set properties of undefined (setting 'onload')
  • page comment ça marche : bouton agrandir
  • select des tags d'une sollicitation
  • changement de statut d'un besoin
  • Tags sur les relances
  • Tags sur les sollicitations

Autre

  • passage à ruby 3.2 + helper pour inclure dsfr
  • passage à la dernière version du dsfr

Questions

  • on veut utiliser css-bundler ou sprockets ou les 2 ?

@PiflY PiflY changed the title Jsbundling + webpack + cssbundling Jsbundling + webpack Feb 26, 2024
@LucienMLD
Copy link
Collaborator

Dans une iframe à la 3eme étape du formulaire l'icône sur le texte d'aide n'apparait pas
Capture d’écran 2024-05-02 à 17 06 59

@clairezed
Copy link
Collaborator Author

Ola, j'ai rien remarqué qui cloche au niveau fonctionnel !

Juste des trucs de style, mais peut-être liés à la MaJ du dsfr. C'est partie pour le jeu des 7 différences :

@PiflY
Copy link
Collaborator

PiflY commented May 6, 2024

En effet, il manquait le css icons-communication du dsfr, qui résout l'icone manquante et probablement le reste des soucis par la même occasion

@clairezed
Copy link
Collaborator Author

clairezed commented May 28, 2024

  • on rétablit comme elles étaient les cartes accueil et relances expert
  • on passe le reste

@clairezed
Copy link
Collaborator Author

Moi ça me semble tout bon :) Une mise en prod la semaine prochaine ?

LucienMLD added 2 commits June 6, 2024 10:14
# Conflicts:
#	app/views/application/_head.html.haml
#	app/views/layouts/pages.html.haml
#	config/initializers/content_security_policy.rb
#	config/webpack/production.js
#	doc/domain_model.pdf
#	package.json
#	yarn.lock
Copy link

gitguardian bot commented Jun 6, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11093449 Triggered Generic Password a336a57 .circleci/config.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Revoke and rotate the secret.

  2. If possible, rewrite git history with git commit --amend and git push --force.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

p.object_src :none
p.style_src :self, :unsafe_inline, 'https://fonts.googleapis.com'
p.script_src :self, :blob, 'https://browser.sentry-cdn.com', 'sentry.io', 'stats.data.gouv.fr', 'https://stats.beta.gouv.fr/', 'https://cdn.jsdelivr.net/', 'https://www.googletagmanager.com/', 'https://www.googleadservices.com', 'https://googleads.g.doubleclick.net', 'https://www.google.com', 'www.pagespeed-mod.com'
p.frame_src :self, 'stats.data.gouv.fr', 'https://stats.data.gouv.fr/', 'browser.sentry-cdn.com', 'https://cdn.jsdelivr.net/', 'https://bid.g.doubleclick.net', 'https://tube.nocturlab.fr', 'https://tpc.googlesyndication.com', 'https://www.youtube-nocookie.com'
p.frame_src :self, 'stats.data.gouv.fr', 'stats.beta.gouv.fr', 'browser.sentry-cdn.com', 'https://cdn.jsdelivr.net/', 'https://bid.g.doubleclick.net', 'https://tube.nocturlab.fr', 'https://tpc.googlesyndication.com', 'https://www.youtube-nocookie.com'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a encore besoin du stats.data.gouv.fr ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non mais on a deux trois csp qu'on peut virer, comme c'etait pas dans le conflit je me suis dit que l'allait faie une carte optimisation des csp

@LucienMLD LucienMLD merged commit 4d115f5 into main Jun 6, 2024
3 checks passed
@LucienMLD LucienMLD deleted the jsbundling-webpack branch June 6, 2024 09:32
@LucienMLD LucienMLD mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MaJ gestion des assets : jsbundling + webpack
3 participants