Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on the first missing response if require_all_response is true #376

Open
RyanMarten opened this issue Jan 17, 2025 · 1 comment
Open
Assignees
Labels
task This is a task

Comments

@RyanMarten
Copy link
Contributor

RyanMarten commented Jan 17, 2025

Currently it continues running and fails later.

(A) In some cases, this is desirable (e.g. when you are going to run it again and then load from cache) since you want to get as far as possible into the data generation job.

(B) In other cases, it is not desirable (e.g. when you are not using the cache and then will re-run the whole job anyway and don't want to waste extra time and $$$ waiting for the run to fail when you know it will fail at the first missing response).

@RyanMarten
Copy link
Contributor Author

Conversation on what the default behavior should be (A) or (B) :

I don't really see how the first case is desirable. Why pay now to put it in the cache and not later when it's fixed?

  • For example if you are running a data generation job over night.You probably want it to complete as much as it can

but then do you really require_all_response?

  • Yes, but this was it doesn't add extra waiting time every time something breaks

@adamoptimizer adamoptimizer self-assigned this Jan 27, 2025
@adamoptimizer adamoptimizer added the task This is a task label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task This is a task
Projects
None yet
Development

No branches or pull requests

3 participants