Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement on croprotate step #31

Open
JarredAllen opened this issue Jul 23, 2019 · 0 comments
Open

Performance improvement on croprotate step #31

JarredAllen opened this issue Jul 23, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@JarredAllen
Copy link
Contributor

It would probably be much better for performance if croprotate were to crop the video smaller first, then rotate, and then crop to the final size. This way, ffmpeg will only have to do bilinear interpolation on a much smaller segment of the image, which should hopefully save a lot of computing power.

I'm probably not going to get around to making this change, because the summer is almost over and I have a lot to do, but it could be something to look into doing to make the code run much faster, especially since the croprotate step takes the most time to run in the entire pipeline.

@JarredAllen JarredAllen added the enhancement New feature or request label Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant