Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline won't handle filenames with spaces correctly #26

Open
JarredAllen opened this issue Jul 8, 2019 · 3 comments
Open

Pipeline won't handle filenames with spaces correctly #26

JarredAllen opened this issue Jul 8, 2019 · 3 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@JarredAllen
Copy link
Contributor

Several of the files depend on the video names not containing spaces in them. This could be worked around through using shlex if such processing is necessary, but it currently doesn't do that.

The current plan does not involve files with spaces in them, but future ones may. I'm leaving this here as a note to future maintainers in case the requirements change.

@JarredAllen JarredAllen added bug Something isn't working wontfix This will not be worked on labels Jul 8, 2019
@aryarm
Copy link
Member

aryarm commented Jul 9, 2019

I know you're not planning on dealing with this issue, but if the problem is that wildcards containing whitespace are being interpreted as separate arguments by the shell, future maintainers might consider using snakemake quoting.

To use it, just add :q at the end of your wildcards (but inside the brackets {}) when you reference them in a shell rule.
I haven't tried it, but theoretically you could also use this on any config variables you put in your shell rules if you place your config variables directly in the shell rule and surround them by brackets:
python3.7 scripts/split.py -s {config[segment-length]:q}

@JarredAllen
Copy link
Contributor Author

Thanks for the tip. However, there are also parts within the code files which also assume there to not be any whitespace in filenames, so that alone will not fix the issue.

@mdonaldsonmatasci
Copy link
Member

mdonaldsonmatasci commented Jul 9, 2019 via email

@JarredAllen JarredAllen changed the title Pipeline won't handle videos with spaces correctly Pipeline won't handle filenames with spaces correctly Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants