Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of reviewers necessary for merge #372

Closed
carreter opened this issue Sep 23, 2023 · 5 comments
Closed

Reduce number of reviewers necessary for merge #372

carreter opened this issue Sep 23, 2023 · 5 comments
Assignees
@TimothyStiles
Labels
devops Improvements to DevOps (e.g. GitHub actions, linting, etc.) easy A quick and easy fix! medium priority The default priority for a new issue. proposal A proposed feature or enhancement

Comments

@carreter
Copy link
Collaborator

At least 6 approving reviews are required by reviewers with write access

Maybe this should be 2?

Originally posted by @Koeng101 in #358 (comment)

Agreed with @Koeng101 here. Currently @TimothyStiles has to approve all PRs. IMO we should set it to 1 for now and bump it to 2 once we add another person who's willing to consistently contribute to the team.
@carreter carreter added devops Improvements to DevOps (e.g. GitHub actions, linting, etc.) easy A quick and easy fix! medium priority The default priority for a new issue. proposal A proposed feature or enhancement labels Sep 23, 2023
@carreter carreter moved this to Proposed in poly development roadmap Sep 23, 2023
@Koeng101
Copy link
Contributor

@TimothyStiles !

@carreter
Copy link
Collaborator Author

Getting the GitHub org set up would also be helpful - having more people (specifically: me) be able to change repo settings would be nice!

@github-project-automation github-project-automation bot moved this from Proposed to Done in poly development roadmap Oct 12, 2023
@carreter
Copy link
Collaborator Author

Seems like the move to the @bebop org has raised this to 6 again...

@carreter carreter reopened this Dec 12, 2023
@TimothyStiles
Copy link
Collaborator

Seems like the move to the @bebop org has raised this to 6 again...

@carreter working on it.

@TimothyStiles
Copy link
Collaborator

@carreter done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimothyStiles TimothyStiles

Labels
devops Improvements to DevOps (e.g. GitHub actions, linting, etc.) easy A quick and easy fix! medium priority The default priority for a new issue. proposal A proposed feature or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Koeng101 @carreter @TimothyStiles