Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"ssl.wrap_socket() is deprecated, use SSLContext.wrap_socket()" #23

Closed
bd808 opened this issue Oct 2, 2023 · 2 comments · Fixed by #24
Closed

"ssl.wrap_socket() is deprecated, use SSLContext.wrap_socket()" #23

bd808 opened this issue Oct 2, 2023 · 2 comments · Fixed by #24
Labels
bug
Milestone
1.0.0

Comments

@bd808
Copy link
Owner

bd808 commented Oct 2, 2023 

2023-10-02T22:41:17Z py.warnings  WARNING : /data/project/jouncebot/jouncebot/venv-k8s-py311/lib/python3.11/site-packages/irc/connection.py:55:
DeprecationWarning: ssl.wrap_socket() is deprecated, use SSLContext.wrap_socket()
  sock = self.wrapper(socket.socket(self.family, socket.SOCK_STREAM))
@bd808 bd808 added the bug label Oct 2, 2023
@bd808 bd808 added this to the 1.0.0 milestone Oct 2, 2023
@bd808
Copy link
Owner Author

bd808 commented Oct 2, 2023

Per https://docs.python.org/3/library/ssl.html#ssl.wrap_socket:

Deprecated since version 3.7: Since Python 3.2 and 2.7.9, it is recommended to use the SSLContext.wrap_socket() instead of wrap_socket(). The top-level function is limited and creates an insecure client socket without server name indication or hostname matching.

@bd808
Copy link
Owner Author

bd808 commented Oct 2, 2023

See also: jaraco/irc#216

bd808 added a commit that referenced this issue Oct 2, 2023
@bd808
Use ssl.SSLContext in ib3.connection.SSL
5af5e9e 
Closes #23
@bd808 bd808 mentioned this issue Oct 3, 2023
Merged
@bd808 bd808 closed this as completed in #24 Oct 3, 2023
bd808 added a commit that referenced this issue Oct 3, 2023
@bd808
Use ssl.SSLContext in ib3.connection.SSL
fc7dddc 
Closes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Use ssl.SSLContext in ib3.connection.SSL bd808/python-ib3
1 participant
@bd808