From 75fd027b0b8340918c353fce1268f96fbd55752c Mon Sep 17 00:00:00 2001 From: mathieulemieux Date: Thu, 6 Oct 2022 13:59:08 -0700 Subject: [PATCH 1/2] Add displayName for MOA signature CategoryVariant --- src/moa/index.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/moa/index.js b/src/moa/index.js index 4486592a..022ba08b 100644 --- a/src/moa/index.js +++ b/src/moa/index.js @@ -268,7 +268,11 @@ const loadVariant = async (conn, moaVariant) => { }); const variantType = await conn.getVocabularyTerm('signature present'); return conn.addVariant({ - content: { reference1: rid(signature), type: rid(variantType) }, + content: { + displayName: `${signature.name.toUpperCase()} signature present`, + reference1: rid(signature), + type: rid(variantType), + }, existsOk: true, target: 'CategoryVariant', }); From 93ae50dc64ef1de97a84205b8c4ed6c16ebc7a76 Mon Sep 17 00:00:00 2001 From: mathieulemieux Date: Tue, 10 Sep 2024 13:47:40 -0700 Subject: [PATCH 2/2] Add comments for KBDEV-993/994 --- src/moa/index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/moa/index.js b/src/moa/index.js index 022ba08b..2a410c79 100644 --- a/src/moa/index.js +++ b/src/moa/index.js @@ -269,6 +269,8 @@ const loadVariant = async (conn, moaVariant) => { const variantType = await conn.getVocabularyTerm('signature present'); return conn.addVariant({ content: { + // KBDEV-994 adding displayName + // TODO: test displayName in KBDEV-993 and remove both comments. displayName: `${signature.name.toUpperCase()} signature present`, reference1: rid(signature), type: rid(variantType),