Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variables in validation module #334

Open
zhemingfan opened this issue Aug 15, 2022 · 2 comments
Open

Unused variables in validation module #334

zhemingfan opened this issue Aug 15, 2022 · 2 comments
Milestone

Comments

@zhemingfan
Copy link
Collaborator

Certain parts of the validate module contains redundant code:
For example - count:
https://github.com/bcgsc/mavis/blob/develop_v3/src/mavis/validate/align.py#L417

Align_options for BWA-MEM, which doesn't use any additional align parameter.
https://github.com/bcgsc/mavis/blob/develop_v3/src/mavis/validate/align.py#L464

These should be removed or better documented.

@zhemingfan zhemingfan added the bug label Aug 15, 2022
@zhemingfan zhemingfan added this to the v3.1.0 milestone Aug 15, 2022
@mattdoug604
Copy link
Member

Hi @zhemingfan,

Just to clarify, did you encounter an error here or is this something you noticed could be be improved upon?

@zhemingfan
Copy link
Collaborator Author

For now, it's just enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants