Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outstanding issues from #343 Basemap switcher #351

Closed
2 tasks done
dawnbcgov opened this issue Jan 16, 2025 · 4 comments · Fixed by #352
Closed
2 tasks done

Fix outstanding issues from #343 Basemap switcher #351

dawnbcgov opened this issue Jan 16, 2025 · 4 comments · Fixed by #352
Assignees

Comments

@dawnbcgov
Copy link
Contributor

dawnbcgov commented Jan 16, 2025

Description:

Noticed some outstanding issues after #343 was merged, tracking those here:

  • Update outline styling to match wireframes
  • Map selector on mobile (Dawn to include screenshots below)
  • Icon for map selector selector do not match map for 'Streets'
  • Map for 'Terrain' updated to Google tiles for Terrain
  • Map selector does not follow zooming icons when using the 'Show Results Pane'

Definition of Ready:

  • Wireframes are included
  • Design / Solution is accepted by Product Owner
@dawnbcgov
Copy link
Contributor Author

Unexpected behaviour on mobile -- the "selected" state doesn't always seem to match what's happening? And on touch seems a bit unreliable: one touch and it opens, other times it takes repeated touches and the opening seems to lag, only fixed by a hard refresh (hard to screenshot that but if needed I could make a video I think)

tested on:
iOS 18.1.1
Safari

Image Image

@kdbelair
Copy link

kdbelair commented Jan 16, 2025

Outlined icons in wireframes that we are looking to replicate:

Image

@popkinj popkinj self-assigned this Jan 16, 2025
@popkinj
Copy link
Collaborator

popkinj commented Jan 16, 2025

Unexpected behaviour on mobile -- the "selected" state doesn't always seem to match what's happening? And on touch seems a bit unreliable: one touch and it opens, other times it takes repeated touches and the opening seems to lag, only fixed by a hard refresh (hard to screenshot that but if needed I could make a video I think)

tested on: iOS 18.1.1 Safari

Image Image

Thanks for testing and documenting. :)

@popkinj popkinj moved this from Todo to In Progress in Organics Info Backlog (EPD Digital Services) Jan 16, 2025
@popkinj
Copy link
Collaborator

popkinj commented Jan 18, 2025

Think I've got this sorted now. I had to more deeply integrate the basemap buttons with the existing leaflet controls.

Image

Image

@popkinj popkinj linked a pull request Jan 18, 2025 that will close this issue
@popkinj popkinj moved this from In Progress to Ready to Test / Review in Organics Info Backlog (EPD Digital Services) Jan 18, 2025
@github-project-automation github-project-automation bot moved this from Ready to Test / Review to Done in Organics Info Backlog (EPD Digital Services) Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants