From da4aeb8c2d0d64d412766b0be962f8c3a95c4b2b Mon Sep 17 00:00:00 2001 From: VineetBala-AOT Date: Mon, 15 Jan 2024 16:48:15 -0800 Subject: [PATCH] Updating changelog --- CHANGELOG.MD | 9 +++++++++ .../src/components/engagement/form/ActionContext.tsx | 4 +--- .../EngagementFormTabs/EngagementTabsContext.tsx | 2 +- .../listing/AdvancedSearch/SearchComponent.tsx | 11 ----------- .../src/components/engagement/view/EmailPanel.tsx | 2 +- .../view/widgets/Subscribe/EmailListModal.tsx | 12 ++---------- met-web/src/components/landing/LandingComponent.tsx | 1 - 7 files changed, 14 insertions(+), 27 deletions(-) diff --git a/CHANGELOG.MD b/CHANGELOG.MD index c76e5a6fc..3337599fa 100644 --- a/CHANGELOG.MD +++ b/CHANGELOG.MD @@ -1,3 +1,12 @@ +## January 15, 2024 + +- **Task** Audit for missing unit tests [🎟️DESENG-436](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-436) + - Corrected tests to execute smoothly in the local environment using development variables. + - Established continuous integration configuration to automatically run tests upon each commit. + - Ensured that the tests pass successfully in our GitHub test environment. +- **Task** Audit for missing unit tests [🎟️DESENG-449](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-449) + - Identified and corrected failing unit test for api and web + ## January 10, 2024 - **Task** Custom Consent per Engagement [🎟️DESENG-456](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-456) diff --git a/met-web/src/components/engagement/form/ActionContext.tsx b/met-web/src/components/engagement/form/ActionContext.tsx index ada581b30..b5e5c1c5e 100644 --- a/met-web/src/components/engagement/form/ActionContext.tsx +++ b/met-web/src/components/engagement/form/ActionContext.tsx @@ -5,7 +5,7 @@ import { getEngagementMetadata, patchEngagementMetadata, } from '../../../services/engagementMetadataService'; -import { useLocation, useNavigate, useParams } from 'react-router-dom'; +import { useNavigate, useParams } from 'react-router-dom'; import { EngagementContext, EngagementForm, EngagementFormUpdate, EngagementParams } from './types'; import { createDefaultEngagement, @@ -55,8 +55,6 @@ export const ActionContext = createContext({ export const ActionProvider = ({ children }: { children: JSX.Element }) => { const { engagementId } = useParams(); - const { search } = useLocation(); - const searchParams = new URLSearchParams(search); const navigate = useNavigate(); const dispatch = useAppDispatch(); diff --git a/met-web/src/components/engagement/form/EngagementFormTabs/EngagementTabsContext.tsx b/met-web/src/components/engagement/form/EngagementFormTabs/EngagementTabsContext.tsx index dfe748780..6b77d9c68 100644 --- a/met-web/src/components/engagement/form/EngagementFormTabs/EngagementTabsContext.tsx +++ b/met-web/src/components/engagement/form/EngagementFormTabs/EngagementTabsContext.tsx @@ -132,7 +132,7 @@ export const EngagementTabsContext = createContext({ }); export const EngagementTabsContextProvider = ({ children }: { children: React.ReactNode }) => { - const { savedEngagement, engagementMetadata } = useContext(ActionContext); + const { savedEngagement } = useContext(ActionContext); const dispatch = useAppDispatch(); const [engagementFormData, setEngagementFormData] = useState({ name: savedEngagement.name || '', diff --git a/met-web/src/components/engagement/listing/AdvancedSearch/SearchComponent.tsx b/met-web/src/components/engagement/listing/AdvancedSearch/SearchComponent.tsx index 79ff759da..c0b94a9bd 100644 --- a/met-web/src/components/engagement/listing/AdvancedSearch/SearchComponent.tsx +++ b/met-web/src/components/engagement/listing/AdvancedSearch/SearchComponent.tsx @@ -6,9 +6,6 @@ import { FormGroup, FormControlLabel, Checkbox, - Select, - SelectChangeEvent, - MenuItem, FormControl, useMediaQuery, Theme, @@ -19,7 +16,6 @@ import { PrimaryButton, SecondaryButton } from '../../../common'; import dayjs from 'dayjs'; import { formatToUTC } from 'components/common/dateHelper'; import { SearchOptions } from './SearchTypes'; -import { AppConfig } from 'config'; interface filterParams { setFilterParams: (newsearchOptions: SearchOptions) => void; @@ -38,13 +34,6 @@ const AdvancedSearch: React.FC = ({ setFilterParams }) => { }; const [statusFilters, setStatusFilters] = useState(initialStatusFilters); - const initialFilterParams = { - status_list: [], - created_from_date: '', - created_to_date: '', - published_from_date: '', - published_to_date: '', - }; const handleStatusFilterChange = (event: React.SyntheticEvent) => { setStatusFilters({ ...statusFilters, diff --git a/met-web/src/components/engagement/view/EmailPanel.tsx b/met-web/src/components/engagement/view/EmailPanel.tsx index ef9a3f590..54f62a936 100644 --- a/met-web/src/components/engagement/view/EmailPanel.tsx +++ b/met-web/src/components/engagement/view/EmailPanel.tsx @@ -1,6 +1,6 @@ import React, { FormEvent, useContext, useState } from 'react'; import { ActionContext } from './ActionContext'; -import { Grid, Checkbox, TextField, FormControl, FormControlLabel, FormHelperText, Stack, Link } from '@mui/material'; +import { Grid, Checkbox, TextField, FormControl, FormControlLabel, FormHelperText, Stack } from '@mui/material'; import { EmailPanelProps } from './types'; import { MetLabel, diff --git a/met-web/src/components/engagement/view/widgets/Subscribe/EmailListModal.tsx b/met-web/src/components/engagement/view/widgets/Subscribe/EmailListModal.tsx index d4aeba1f6..c26c7003a 100644 --- a/met-web/src/components/engagement/view/widgets/Subscribe/EmailListModal.tsx +++ b/met-web/src/components/engagement/view/widgets/Subscribe/EmailListModal.tsx @@ -1,27 +1,23 @@ import React, { useState, useContext } from 'react'; import { MetDisclaimer } from 'components/common'; import { ActionContext } from '../../ActionContext'; -import { Link, Typography, Box, useMediaQuery, Theme } from '@mui/material'; -import { useAppDispatch, useAppSelector } from 'hooks'; +import { useAppDispatch } from 'hooks'; import { openNotificationModal } from 'services/notificationModalService/notificationModalSlice'; import EmailModal from 'components/common/Modals/EmailModal'; import { createSubscribeEmailVerification } from 'services/emailVerificationService'; import { createSubscription } from 'services/subscriptionService'; import { EmailVerificationType } from 'models/emailVerification'; import { SubscriptionType } from 'constants/subscriptionType'; -import { TenantState } from 'reduxSlices/tenantSlice'; import { Editor } from 'react-draft-wysiwyg'; import { getEditorStateFromRaw } from 'components/common/RichTextEditor/utils'; const EmailListModal = ({ open, setOpen }: { open: boolean; setOpen: (open: boolean) => void }) => { const dispatch = useAppDispatch(); - const isSmallScreen: boolean = useMediaQuery((theme: Theme) => theme.breakpoints.down('sm')); - const { savedEngagement, engagementMetadata } = useContext(ActionContext); + const { savedEngagement } = useContext(ActionContext); const defaultType = SubscriptionType.ENGAGEMENT; const [email, setEmail] = useState(''); const [isSaving, setIsSaving] = useState(false); const [subscriptionType, setSubscriptionType] = useState(defaultType); - const tenant: TenantState = useAppSelector((state) => state.tenant); const sendEmail = async () => { try { @@ -95,10 +91,6 @@ const EmailListModal = ({ open, setOpen }: { open: boolean; setOpen: (open: bool } }; - const handleSubscriptionChange = (type: string) => { - setSubscriptionType(type); - }; - return (