diff --git a/met-api/src/met_api/resources/widget_poll.py b/met-api/src/met_api/resources/widget_poll.py index eaae6e784..799932803 100644 --- a/met-api/src/met_api/resources/widget_poll.py +++ b/met-api/src/met_api/resources/widget_poll.py @@ -14,6 +14,7 @@ from met_api.utils.ip_util import hash_ip API = Namespace('widget_polls', description='Endpoints for Poll Widget Management') +INVALID_REQUEST_MESSAGE = 'Invalid request format' @cors_preflight('GET, POST') @@ -40,7 +41,7 @@ def post(widget_id): request_json = request.get_json() valid_format, errors = Polls.validate_request_format(request_json) if not valid_format: - return {'message': 'Invalid response format', 'errors': errors}, HTTPStatus.BAD_REQUEST + return {'message': INVALID_REQUEST_MESSAGE, 'errors': errors}, HTTPStatus.BAD_REQUEST widget_poll = WidgetPollService().create_poll(widget_id, request_json) return WidgetPollSchema().dump(widget_poll), HTTPStatus.OK except BusinessException as err: @@ -69,7 +70,7 @@ def patch(widget_id, poll_widget_id): request_json = request.get_json() valid_format, errors = Poll.validate_request_format(request_json) if not valid_format: - return {'message': 'Invalid response format', 'errors': errors}, HTTPStatus.BAD_REQUEST + return {'message': INVALID_REQUEST_MESSAGE, 'errors': errors}, HTTPStatus.BAD_REQUEST widget_poll = WidgetPollService().update_poll(widget_id, poll_widget_id, request_json) return WidgetPollSchema().dump(widget_poll), HTTPStatus.OK @@ -98,7 +99,7 @@ def post(widget_id, poll_widget_id): response_data = request.get_json() valid_format, errors = PollResponseRecord.validate_request_format(response_data) if not valid_format: - return {'message': 'Invalid response format', 'errors': errors}, HTTPStatus.BAD_REQUEST + return {'message': INVALID_REQUEST_MESSAGE, 'errors': errors}, HTTPStatus.BAD_REQUEST response_dict = PollResponseRecord.prepare_response_data(response_data, widget_id, poll_widget_id) diff --git a/met-api/tests/unit/api/test_widget_poll.py b/met-api/tests/unit/api/test_widget_poll.py index 1d6874ec1..13ae08479 100644 --- a/met-api/tests/unit/api/test_widget_poll.py +++ b/met-api/tests/unit/api/test_widget_poll.py @@ -59,7 +59,7 @@ def test_create_poll_widget(client, jwt, session, setup_admin_user_and_claims): """Assert that a poll widget can be POSTed.""" # Test setup: create a poll widget model - user, claims = setup_admin_user_and_claims + _, claims = setup_admin_user_and_claims headers = factory_auth_header(jwt=jwt, claims=claims) engagement = factory_engagement_model() @@ -111,7 +111,7 @@ def test_create_poll_widget(client, jwt, session, setup_admin_user_and_claims): def test_update_poll_widget(client, jwt, session, setup_admin_user_and_claims): """Assert that a poll widget can be PATCHed.""" # Test setup: create and post a poll widget model - user, claims = setup_admin_user_and_claims + _, claims = setup_admin_user_and_claims headers = factory_auth_header(jwt=jwt, claims=claims) engagement = factory_engagement_model() diff --git a/met-api/tests/unit/services/test_widget_poll_service.py b/met-api/tests/unit/services/test_widget_poll_service.py index 8169bf6cc..053ecf3a8 100644 --- a/met-api/tests/unit/services/test_widget_poll_service.py +++ b/met-api/tests/unit/services/test_widget_poll_service.py @@ -142,12 +142,6 @@ def test_check_already_polled(session): already_polled = WidgetPollService.check_already_polled(poll.id, response_data['participant_id'], 1) assert already_polled is True - # Test wrong poll id - with pytest.raises(BusinessException) as exc_info: - _ = WidgetPollService.check_already_polled('wrong_string', response_data['participant_id'], 1) - - assert exc_info.value.status_code == HTTPStatus.INTERNAL_SERVER_ERROR - def test_is_poll_active(session): """Check if poll is active or not."""