From 7c23bfce6c23a770c643cc6922c5aeaa3af32c5e Mon Sep 17 00:00:00 2001 From: Ratheesh kumar R Date: Tue, 27 Feb 2024 16:02:12 -0800 Subject: [PATCH] DESENG-496: Fixed Comments cannot be approved Added missing transactional decorator --- CHANGELOG.MD | 4 ++++ met-api/src/met_api/services/submission_service.py | 1 + 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.MD b/CHANGELOG.MD index a1cdd0b77..c424aa2f0 100644 --- a/CHANGELOG.MD +++ b/CHANGELOG.MD @@ -1,3 +1,7 @@ +## February 27, 2024 +- **Bug Fix**Comments cannot be approved while reviewing [DESENG-496](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-496) + - Fixed by adding a missing decorator for transactional methods. + ## February 26, 2024 - **Task**Models for dynamic engagement pages [DESENG-500](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-500) - Implemented endpoints for dynamic engagement pages, including summary and custom sections. diff --git a/met-api/src/met_api/services/submission_service.py b/met-api/src/met_api/services/submission_service.py index abfeb3410..9e640c862 100644 --- a/met-api/src/met_api/services/submission_service.py +++ b/met-api/src/met_api/services/submission_service.py @@ -144,6 +144,7 @@ def _validate_fields(submission): raise ValueError('Engagement not open to submissions') @classmethod + @transactional() def review_comment(cls, submission_id, staff_review_details: dict, external_user_id) -> SubmissionSchema: """Review comment.""" user = StaffUserService.get_user_by_external_id(external_user_id)