From 7baa5e5373d02bfee6681fc1010c9318761cc7ce Mon Sep 17 00:00:00 2001
From: Ratheesh kumar R <108045773+ratheesh-aot@users.noreply.github.com>
Date: Thu, 1 Feb 2024 11:34:22 -0800
Subject: [PATCH] DESENG-489: engagement core to engagement content (#2371)
* DESENG-489: engagement core to engagement content
* Adding unit test
* Space correction
---
CHANGELOG.MD | 3 +++
.../engagement/form/EngagementFormTabs/FormTabs.tsx | 6 +++---
.../engagement/form/EngagementFormTabs/constants.ts | 4 ++--
.../form/edit/EngagementForm.Edit.One.test.tsx | 13 +++++++++++++
4 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/CHANGELOG.MD b/CHANGELOG.MD
index 3b680d0e3..e34671060 100644
--- a/CHANGELOG.MD
+++ b/CHANGELOG.MD
@@ -1,3 +1,6 @@
+## February 01, 2024
+- **Task** Change name from "Engagement Core" to "Engagement Content". [🎟️DESENG-489](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-489)
+
## January 29, 2024
- **Task** Updated Babel Traverse library. [🎟️DESENG-474](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-474)
- Run `npm audit fix` to update the vulnerable Babel traverse library.
diff --git a/met-web/src/components/engagement/form/EngagementFormTabs/FormTabs.tsx b/met-web/src/components/engagement/form/EngagementFormTabs/FormTabs.tsx
index 618ca5e3d..432a944a1 100644
--- a/met-web/src/components/engagement/form/EngagementFormTabs/FormTabs.tsx
+++ b/met-web/src/components/engagement/form/EngagementFormTabs/FormTabs.tsx
@@ -9,7 +9,7 @@ import EngagementAdditionalDetails from './AdditionalDetails';
import EngagementSettings from './Settings';
const FormTabs = () => {
- const [value, setValue] = React.useState<EngagementFormTabValues>(ENGAGEMENT_FORM_TABS.CORE);
+ const [value, setValue] = React.useState<EngagementFormTabValues>(ENGAGEMENT_FORM_TABS.CONTENT);
return (
<Box sx={{ width: '100%', typography: 'body1' }}>
@@ -24,13 +24,13 @@ const FormTabs = () => {
}}
variant="scrollable"
>
- <MetTab label="Engagement Core" value={ENGAGEMENT_FORM_TABS.CORE} />
+ <MetTab label="Engagement Content" value={ENGAGEMENT_FORM_TABS.CONTENT} />
<MetTab label="Additional Details" value={ENGAGEMENT_FORM_TABS.ADDITIONAL} />
<MetTab label="User Management" value={ENGAGEMENT_FORM_TABS.USER_MANAGEMENT} />
<MetTab label="Settings" value={ENGAGEMENT_FORM_TABS.SETTINGS} />
</MetTabList>
</Box>
- <MetTabPanel value={ENGAGEMENT_FORM_TABS.CORE}>
+ <MetTabPanel value={ENGAGEMENT_FORM_TABS.CONTENT}>
<EngagementForm />
</MetTabPanel>
<MetTabPanel value={ENGAGEMENT_FORM_TABS.ADDITIONAL}>
diff --git a/met-web/src/components/engagement/form/EngagementFormTabs/constants.ts b/met-web/src/components/engagement/form/EngagementFormTabs/constants.ts
index 85593c067..1cd6983d8 100644
--- a/met-web/src/components/engagement/form/EngagementFormTabs/constants.ts
+++ b/met-web/src/components/engagement/form/EngagementFormTabs/constants.ts
@@ -1,7 +1,7 @@
-export type EngagementFormTabValues = 'core' | 'settings' | 'User Management' | 'additional';
+export type EngagementFormTabValues = 'content' | 'settings' | 'User Management' | 'additional';
export const ENGAGEMENT_FORM_TABS: { [x: string]: EngagementFormTabValues } = {
- CORE: 'core',
+ CONTENT: 'content',
ADDITIONAL: 'additional',
USER_MANAGEMENT: 'User Management',
SETTINGS: 'settings',
diff --git a/met-web/tests/unit/components/engagement/form/edit/EngagementForm.Edit.One.test.tsx b/met-web/tests/unit/components/engagement/form/edit/EngagementForm.Edit.One.test.tsx
index d93fca1ce..fde69dd1b 100644
--- a/met-web/tests/unit/components/engagement/form/edit/EngagementForm.Edit.One.test.tsx
+++ b/met-web/tests/unit/components/engagement/form/edit/EngagementForm.Edit.One.test.tsx
@@ -112,6 +112,19 @@ describe('Engagement form page tests', () => {
setupEnv();
});
+ test('Engagement form tabs and their titles should be populated correctly', async () => {
+ useParamsMock.mockReturnValue({ engagementId: '1' });
+ render(<EngagementForm />);
+
+ await waitFor(() => {
+ expect(screen.getByText('Engagement Content')).toBeInTheDocument();
+ });
+
+ expect(screen.getByText('Additional Details')).toBeInTheDocument();
+ expect(screen.getByText('User Management')).toBeInTheDocument();
+ expect(screen.getByText('Settings')).toBeInTheDocument();
+ });
+
test('Engagement form with saved engagement should display saved info', async () => {
useParamsMock.mockReturnValue({ engagementId: '1' });
render(<EngagementForm />);