From 1045b42e7e9074eb588e6e036287432abbe09303 Mon Sep 17 00:00:00 2001 From: Ratheesh kumar R Date: Fri, 15 Mar 2024 10:03:55 -0700 Subject: [PATCH] DESENG-515: Fixing code cov comments --- .../src/met_api/services/event_item_translation_service.py | 5 ----- .../met_api/services/subscribe_item_translation_service.py | 7 +------ met-api/tests/utilities/factory_scenarios.py | 6 +++--- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/met-api/src/met_api/services/event_item_translation_service.py b/met-api/src/met_api/services/event_item_translation_service.py index 922f5831b..e561374d7 100644 --- a/met-api/src/met_api/services/event_item_translation_service.py +++ b/met-api/src/met_api/services/event_item_translation_service.py @@ -31,11 +31,6 @@ def get_engagement_id(event_id): error='Event not found', ) widget = WidgetService.get_widget_by_id(widget_event.widget_id) - if not widget: - raise BusinessException( - status_code=HTTPStatus.NOT_FOUND, - error='Widget not found', - ) return widget.engagement_id @staticmethod diff --git a/met-api/src/met_api/services/subscribe_item_translation_service.py b/met-api/src/met_api/services/subscribe_item_translation_service.py index 2f8cc2fbd..5ed9a9948 100644 --- a/met-api/src/met_api/services/subscribe_item_translation_service.py +++ b/met-api/src/met_api/services/subscribe_item_translation_service.py @@ -30,17 +30,12 @@ def get_subscribe_item_translation(subscribe_item_id=None, language_id=None): def get_engagement_id(widget_subscribe_id): """Get engagement id widget_subscribe_id.""" widget_subscribe = WidgetSubscribeService.get_by_id(widget_subscribe_id) - if not widget_subscribe_id: + if not widget_subscribe: raise BusinessException( status_code=HTTPStatus.NOT_FOUND, error='Subscribe widget not found', ) widget = WidgetService.get_widget_by_id(widget_subscribe.widget_id) - if not widget: - raise BusinessException( - status_code=HTTPStatus.NOT_FOUND, - error='Widget not found', - ) return widget.engagement_id @staticmethod diff --git a/met-api/tests/utilities/factory_scenarios.py b/met-api/tests/utilities/factory_scenarios.py index 964925a52..37508402f 100644 --- a/met-api/tests/utilities/factory_scenarios.py +++ b/met-api/tests/utilities/factory_scenarios.py @@ -942,7 +942,7 @@ class TestSubscribeItemTranslationInfo(dict, Enum): translate_info1 = { 'subscribe_item_id': 1, 'language_id': 2, - 'description': 'Description in another language', + 'description': fake.text(), } @@ -952,7 +952,7 @@ class TestEventItemTranslationInfo(dict, Enum): event_item_info1 = { 'event_item_id': 1, 'language_id': 2, - 'description': 'Description in another language', + 'description': fake.text(), 'location_name': 'Location name', 'location_address': 'location address', 'url': fake.url(), @@ -966,7 +966,7 @@ class TestTimelineEventTranslationInfo(dict, Enum): timeline_event_info1 = { 'timeline_event_id': 1, 'language_id': 2, - 'description': 'Description in another language', + 'description': fake.text(), 'time': datetime.now().strftime('%Y-%m-%d'), }