Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Select to use ListboxSection instead of Section #503

Closed
mkernohanbc opened this issue Nov 26, 2024 · 1 comment · Fixed by #504
Closed

Update Select to use ListboxSection instead of Section #503

mkernohanbc opened this issue Nov 26, 2024 · 1 comment · Fixed by #504
Assignees
@mkernohanbc
Labels
enhancement New feature or request
Milestone
Components v0.5.0

Comments

@mkernohanbc
Copy link
Contributor

The latest version of React Aria Components deprecates the generic Section component, in favour of "specific components for each parent collection component, e.g. ListBoxSection and MenuSection".

This affects our Select component, which uses Section. We will need to refactor this component to properly support ListBoxSection alongside #500.
@mkernohanbc mkernohanbc added the enhancement New feature or request label Nov 26, 2024
@mkernohanbc mkernohanbc added this to the Components v0.5.0 milestone Nov 26, 2024
@mkernohanbc mkernohanbc self-assigned this Nov 26, 2024
@mkernohanbc
Copy link
Contributor Author

@Supriya-Arora tagging you for visibility, but I'm happy to take a first pass at this.

@mkernohanbc mkernohanbc linked a pull request Nov 27, 2024 that will close this issue
Refactor Select to use ListBoxSection #504
Merged
@mkernohanbc mkernohanbc mentioned this issue Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkernohanbc mkernohanbc

Labels
enhancement New feature or request
Projects
None yet
Milestone
Components v0.5.0
Development

Successfully merging a pull request may close this issue.

Refactor Select to use ListBoxSection bcgov/design-system
1 participant
@mkernohanbc