getAppAuthMode does not evaluate configuration values

[pbolduc]

Describe the bug

The getAppAuthMode function does not evaluate the configuration. It only checks if the configuration is defined. This causes wrong evaluation if values are set but set to false.

common-object-management-service/app/src/components/utils.js

Lines 40 to 48 in a32d4a8

	getAppAuthMode() {
	const basicAuth = config.has('basicAuth.enabled');
	const oidcAuth = config.has('keycloak.enabled');
	if (!basicAuth && !oidcAuth) return AuthMode.NOAUTH;
	else if (basicAuth && !oidcAuth) return AuthMode.BASICAUTH;
	else if (!basicAuth && oidcAuth) return AuthMode.OIDCAUTH;
	else return AuthMode.FULLAUTH; // basicAuth && oidcAuth
	},

In the above function, the code tests if a config value exists instead of getting config.

So if I define KC_ENABLED=false, the service starts up with OIDC configuration enabled. Since I do not have OIDC configuration values, the pod dies saying Configuration property \"keycloak.clientId\" is not defined

To Reproduce

Steps to reproduce the behavior:

1. Deploy service with KC_ENABLED=false set but do not set any other KC vars
2. See error at startup saying keycloak.clientId is not defined.

Expected behavior

If I configured KC_ENABLED=false, it should not expect keycloak configuration to be defined.

Screenshots

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context

[TimCsaky]

You make a good point.. and it's a usability issue we want to resolve.
currently, the config values are parsed as strings. so "false" = true`
it appears recent versions of the node-config library allow us to parse booleans.
We're going to look into this. but I expect it will be a v.0.5 change.

[pbolduc]

config.has('basicAuth.enabled') only checks if there is a value in basicAuth.enabled, but does not check the value. You could change it to:

const basicAuth = config.has('basicAuth.enabled') && config.basicAuth.enabled === true

It is like having a configuration value format.hard-disk and I have it set to false, but boom, my disk gets formatted.