Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak Variables are required when Keycloak is disabled #69

Closed
dhaselhan opened this issue Sep 1, 2022 · 2 comments
Closed

Keycloak Variables are required when Keycloak is disabled #69

dhaselhan opened this issue Sep 1, 2022 · 2 comments

Comments

@dhaselhan
Copy link

dhaselhan commented Sep 1, 2022

Describe the bug

The Keycloak Server URL and Keycloak Realm are required to be set to open the documentation page, even when keycloak is not enabled.

To Reproduce

Do not set any Keycloak variables on the docker image
Run the image
Navigate to http://localhost:3000/api/v1/docs

You will receive the following error and a 500:
{"component":"app","level":"error","message":"Configuration property "keycloak.realm" is not defined","stack":"Error: Configuration property "keycloak.realm" is not defined\n at Config.get (/opt/app-root/src/app/node_modules/config/lib/config.js:182:11)\n at getSpec (/opt/app-root/src/app/src/routes/v1/docs.js:12:114)\n at /opt/app-root/src/app/src/routes/v1/docs.js:24:59\n at Layer.handle [as handle_request] (/opt/app-root/src/app/node_modules/express/lib/router/layer.js:95:5)\n at next (/opt/app-root/src/app/node_modules/express/lib/router/route.js:144:13)\n at Route.dispatch (/opt/app-root/src/app/node_modules/express/lib/router/route.js:114:3)\n at Layer.handle [as handle_request] (/opt/app-root/src/app/node_modules/express/lib/router/layer.js:95:5)\n at /opt/app-root/src/app/node_modules/express/lib/router/index.js:284:15\n at Function.process_params (/opt/app-root/src/app/node_modules/express/lib/router/index.js:346:12)\n at next (/opt/app-root/src/app/node_modules/express/lib/router/index.js:280:10)","timestamp":"2022-09-01T18:10:39.153Z"}

Expected behavior

When keycloak is not enabled, the app should not require Keycloak variables to be set

@jujaga
Copy link
Member

jujaga commented Sep 1, 2022

Thank you for filing this issue @dhaselhan . We've addressed and applied the bugfix in #70 .

@jujaga jujaga closed this as completed Sep 1, 2022
@dhaselhan
Copy link
Author

Thanks for the fast fix! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants