Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata documenation does not mention implemented limits on key and value lengths #119

Closed
pbolduc opened this issue Feb 1, 2023 · 1 comment

Comments

@pbolduc
Copy link
Contributor

pbolduc commented Feb 1, 2023

The metadata wiki page uses the same wording as the AWS: Working with object metadata documenation. This documenation only calls out that:

the user-defined metadata is limited to 2 KB in size. The size of user-defined metadata is measured by taking the sum of the number of bytes in the UTF-8 encoding of each key and value.

The database implementation puts a limit of 255 for each the key and value. These limits do seem reasonable for the kind of service COMS is used for. It would be good to ensure the documenation reflects this design point. You may want to consider increasing the value length to match the tag value length for consistency.

This issue does not impact our use of COMS.

@jujaga
Copy link
Member

jujaga commented Mar 14, 2023

Thanks for the discrepancy catch. I've added a maximum length annotation to the OpenAPI spec discussing the x-amz-meta-* header so that it expects a maximum length value of 255 to align with database implementation. This will appear in the v0.4.0 COMS release.

@jujaga jujaga closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants